Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenBSD support #55

Merged
merged 4 commits into from
Dec 2, 2023
Merged

Add OpenBSD support #55

merged 4 commits into from
Dec 2, 2023

Conversation

jasperla
Copy link
Contributor

@jasperla jasperla commented Nov 13, 2023

With these changes I can run rp++ on OpenBSD.

Instead print a helpful message with the type and this also allows rp
to returned the intended message (and not crash).
@jasperla jasperla changed the title Fix building on OpenBSD Add OpenBSD support Nov 13, 2023
@0vercl0k
Copy link
Owner

0vercl0k commented Nov 26, 2023

Woot, awesome! Thanks for sending this in - just a quick question; any reason to remove the std::abort? (and sorry for the lag!)

Cheers

@jasperla
Copy link
Contributor Author

The reason I removed the abort() call was because it seems the original intent was to return the "unknown type" message all along. Otherwise either the abort() or "unknown type" message should be removed as not both could be executed. I figured it's more helpful to print an informative message instead of crashing :-)

@0vercl0k
Copy link
Owner

0vercl0k commented Nov 29, 2023 via email

@0vercl0k 0vercl0k merged commit 62d0940 into 0vercl0k:master Dec 2, 2023
5 checks passed
@0vercl0k
Copy link
Owner

0vercl0k commented Dec 2, 2023

Thank you again 🙏!

@jasperla
Copy link
Contributor Author

jasperla commented Dec 8, 2023

Thanks for the merge and the abort() touch-up!

@jasperla jasperla deleted the openbsd branch December 8, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants