-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove local db
from aggsender
#197
Draft
goran-ethernal
wants to merge
5
commits into
develop
Choose a base branch
from
CDK-594-aggsender-remove-db-use-memory
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
changed the title
CDK-594-aggsender-remove-db-use-memory
feat: remove local Nov 22, 2024
db
from aggsender
goran-ethernal
changed the base branch from
main
to
feature/aggsender_recovery
November 22, 2024 11:00
goran-ethernal
force-pushed
the
CDK-594-aggsender-remove-db-use-memory
branch
from
November 22, 2024 11:40
c9a4f13
to
512bfa1
Compare
goran-ethernal
requested review from
joanestebanr,
Stefan-Ethernal and
arnaubennassar
November 22, 2024 11:49
vcastellm
reviewed
Nov 25, 2024
vcastellm
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase to deduce diff?
Stefan-Ethernal
force-pushed
the
CDK-594-aggsender-remove-db-use-memory
branch
from
November 25, 2024 12:03
512bfa1
to
dd6efaf
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the local
aggsender
db
, and uses in memory saving of the last sent certificate.On startup, the
aggsender
will get the last sent certificate for its network by using theinterop_getLatestKnownCertificateHeader
rpc endpoint onagglayer
. If it isnil
, it means thatagglayer
doesn't have any certificates from our network. If it has, we will save it in memory as the last sent certificate.Then, the flow is as it was:
agglayer
has no certificates from our network), or if it's status isSettled
orInError
,aggsender
will proceed to build a new certificate.Settled
orInError
it means we can not build a new certificate, so we wait for the next chance to build it.Pros of removing local
aggsender
db
:agglayer
as a source of truth.aggsender
config is smaller.aggsender
is faster since it saves the last sent certificate in memory, and it doesn't need to querydb
.Cons:
aggsenders
sending certs with sameNetworkID
, or someone was manually sending certificates to theagglayer
.