Skip to content

Commit

Permalink
docs: minor comment
Browse files Browse the repository at this point in the history
  • Loading branch information
praetoriansentry committed Sep 15, 2023
1 parent 6b24656 commit dd8d09f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion cmd/loadtest/recall.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ func getRecentBlocks(ctx context.Context, ec *ethclient.Client, c *ethrpc.Client
return nil, err
}

// FIXME the batch size of 25 is hard coded and probably should at least be a constant or a parameter
// FIXME the batch size of 25 is hard coded and probably should at least be a constant or a parameter. This limit is
// different than the actual json RPC batch size of 999. Because we're fetching blocks, its' more likely that we hit
// a response size limit rather than a batch length limit
rawBlocks, err := util.GetBlockRangeInPages(ctx, bn-*inputLoadTestParams.RecallLength, bn, 25, c)
return rawBlocks, err
}
Expand Down

0 comments on commit dd8d09f

Please sign in to comment.