-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feijoa Circuits #280
Merged
Merged
Feijoa Circuits #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerTaule
force-pushed
the
feature/feijoa-circuits
branch
6 times, most recently
from
March 15, 2024 08:53
5dd83f5
to
8f9a470
Compare
RogerTaule
force-pushed
the
feature/feijoa-circuits
branch
2 times, most recently
from
March 20, 2024 16:01
0a8dca4
to
df8cba2
Compare
zkronos73
approved these changes
Mar 20, 2024
src/sm/sm_rom.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a fix over sm_rom.js, better in other PR.
RogerTaule
force-pushed
the
feature/feijoa-circuits
branch
3 times, most recently
from
March 26, 2024 13:01
a6beaf3
to
843ac47
Compare
RogerTaule
force-pushed
the
feature/feijoa-circuits
branch
from
April 1, 2024 14:06
6fc90e7
to
ab09ca2
Compare
RogerTaule
force-pushed
the
feature/feijoa-circuits
branch
from
April 8, 2024 16:16
ab09ca2
to
1d4a527
Compare
krlosMata
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸
RogerTaule
force-pushed
the
feature/feijoa-circuits
branch
from
April 9, 2024 10:19
1d4a527
to
761d1fe
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a first version of the Feijoa circuits, which includes (blob_inner_compressor, blob_inner_recursive, blob_outer, blob_outer_recursive2, blob_outer_recursivef and final).
To do so, old recursive templates has been generalized so it can be reused. A new template for generating the blob_outer proof (which aggregates a blob_inner_recursive1 proof and a batch_recursive_proof) has been created.
In the final proof, aggregator address has been moved to the end to be compatible with future aggregation layer changes.
Two functions has been created to simplify the setup process.