Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feijoa Circuits #280

Merged
merged 16 commits into from
Apr 9, 2024
Merged

Feijoa Circuits #280

merged 16 commits into from
Apr 9, 2024

Conversation

RogerTaule
Copy link
Contributor

This PR adds a first version of the Feijoa circuits, which includes (blob_inner_compressor, blob_inner_recursive, blob_outer, blob_outer_recursive2, blob_outer_recursivef and final).
To do so, old recursive templates has been generalized so it can be reused. A new template for generating the blob_outer proof (which aggregates a blob_inner_recursive1 proof and a batch_recursive_proof) has been created.
In the final proof, aggregator address has been moved to the end to be compatible with future aggregation layer changes.
Two functions has been created to simplify the setup process.

@RogerTaule RogerTaule requested a review from zkronos73 March 8, 2024 14:35
@cla-bot cla-bot bot added the cla-signed label Mar 8, 2024
@RogerTaule RogerTaule force-pushed the feature/feijoa-circuits branch 6 times, most recently from 5dd83f5 to 8f9a470 Compare March 15, 2024 08:53
@RogerTaule RogerTaule force-pushed the feature/feijoa-circuits branch 2 times, most recently from 0a8dca4 to df8cba2 Compare March 20, 2024 16:01
src/sm/sm_rom.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a fix over sm_rom.js, better in other PR.

@RogerTaule RogerTaule force-pushed the feature/feijoa-circuits branch 3 times, most recently from a6beaf3 to 843ac47 Compare March 26, 2024 13:01
@RogerTaule RogerTaule force-pushed the feature/feijoa-circuits branch from 6fc90e7 to ab09ca2 Compare April 1, 2024 14:06
@RogerTaule RogerTaule force-pushed the feature/feijoa-circuits branch from ab09ca2 to 1d4a527 Compare April 8, 2024 16:16
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@RogerTaule RogerTaule force-pushed the feature/feijoa-circuits branch from 1d4a527 to 761d1fe Compare April 9, 2024 10:19
@krlosMata krlosMata merged commit 29afced into develop-feijoa Apr 9, 2024
2 of 3 checks passed
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants