Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes blob #323

Merged
merged 1 commit into from
Apr 3, 2024
Merged

small fixes blob #323

merged 1 commit into from
Apr 3, 2024

Conversation

laisolizq
Copy link
Contributor

No description provided.

@laisolizq laisolizq requested review from krlosMata and zkronos73 April 2, 2024 15:28
@cla-bot cla-bot bot added the cla-signed label Apr 2, 2024
@@ -79,6 +81,7 @@ module.exports = class FtBlob extends Helper {
// get hashP data
const bytesHash = byteArray2HexString(ctx.hashP[addressHashP].data);
this.finalTrace.batch_data.push(bytesHash);
this.finalTrace.num_batches = this.finalTrace.num_batches + 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this variable is on the ROM available it should be taken from there

@laisolizq laisolizq force-pushed the feature/small-fixes-blob branch from 3e79c14 to 2183718 Compare April 3, 2024 09:17
Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit bbdfd12 into develop-feijoa Apr 3, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants