Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config assumes endpoints are http protocol #403

Closed
Mirko-von-Leipzig opened this issue Jul 11, 2024 · 2 comments · Fixed by #556
Closed

Config assumes endpoints are http protocol #403

Mirko-von-Leipzig opened this issue Jul 11, 2024 · 2 comments · Fixed by #556

Comments

@Mirko-von-Leipzig
Copy link
Contributor

Endpoints are defined as (host, port) tuples and then make the assumption that the protocol is always http.

We probably want to at least support https as well.

@varun-doshi
Copy link

I can take this up with some more information about how to proceed

@Mirko-von-Leipzig
Copy link
Contributor Author

@varun-doshi I think the least intrusive approach would be to add an enum to the endpoint like:

enum Protocol {
    Http,
    Https,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants