Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added https support in endpoint config #556

Merged
merged 3 commits into from
Dec 2, 2024
Merged

feat: added https support in endpoint config #556

merged 3 commits into from
Dec 2, 2024

Conversation

varun-doshi
Copy link

Ref #403

Added https support in the endpoints struct.
By default, all default calls are to http type only as expected for localhost.

Mirko-von-Leipzig
Mirko-von-Leipzig requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just some minor changes :)

crates/utils/src/config.rs Outdated Show resolved Hide resolved
crates/utils/src/config.rs Show resolved Hide resolved
bin/node/src/config.rs Outdated Show resolved Hide resolved
@Mirko-von-Leipzig Mirko-von-Leipzig linked an issue Nov 29, 2024 that may be closed by this pull request
Config assumes endpoints are http protocol #403
Closed
Mirko-von-Leipzig
Mirko-von-Leipzig reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an entry into the CHANGELOG.md for this?

Something like "Support Https in endpoint configuration" to the Enhancements section. Note that we sort these chronologically, so yours should come after the Added GetAccountProofs endpoint (#506).

Mirko-von-Leipzig
Mirko-von-Leipzig requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a couple more minor fixups :)

crates/utils/src/config.rs Outdated Show resolved Hide resolved
bin/node/src/config.rs Show resolved Hide resolved
@Mirko-von-Leipzig
Copy link
Contributor

And then lastly if you could ensure formatting and tests pass - you can check this locally by running make lint and make test respectively.

Mirko-von-Leipzig
Mirko-von-Leipzig approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you very much!

@Mirko-von-Leipzig Mirko-von-Leipzig merged commit 54095db into 0xPolygonMiden:next Dec 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mirko-von-Leipzig Mirko-von-Leipzig Mirko-von-Leipzig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config assumes endpoints are http protocol
2 participants
@varun-doshi @Mirko-von-Leipzig