Add faucet enabling testing #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing to keep in mind is that this PR will be merged soon (and the Client will be released to crates.io either today or tomorrow) so that might imply some minor changes here. |
Dominik1999
requested review from
igamigo and
bobbinth
and removed request for
Dominik1999 and
bobbinth
|
Let merge :) @igamigo can you review this today or tomorrow? |
Will be checking it out in a few hours! |
igamigo
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
LGTM! Left some non-blocking considerations.
A couple more general points:
- For the website, it seems that the button should post to the server and so you would get some feedback from the browser in terms of the request. The deployed website did not show any feedback and this would be confusing in terms of waiting for the response
- The deployed website is still up, should it be taken offline for now?
mFragaBA
reviewed
Mar 26, 2024
mFragaBA
reviewed
Mar 26, 2024
mFragaBA
reviewed
Mar 26, 2024
mFragaBA
reviewed
Mar 26, 2024
mFragaBA
reviewed
Mar 26, 2024
mFragaBA
reviewed
Mar 26, 2024
mFragaBA
reviewed
Mar 26, 2024
|
@phklive - could you add a short README to the |
bobbinth
reviewed
Mar 29, 2024
Comment on lines
+1
to
+4
| [package] | ||
| name = "miden-node-faucet" | ||
| version = "0.1.0" | ||
| edition = "2021" |
There was a problem hiding this comment.
We should do this the same way as we do it in all other crates (e.g., see here).
bobbinth
reviewed
Mar 29, 2024
| version = "0.1.0" | ||
| edition = "2021" | ||
|
|
||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html |
There was a problem hiding this comment.
nit: this can probably be deleted.
bobbinth
reviewed
Mar 29, 2024
Comment on lines
+12
to
+27
| [dependencies] | ||
| actix-web = "4" | ||
| actix-files = "0.6.5" | ||
| actix-cors = "0.7.0" | ||
| derive_more = "0.99.17" | ||
| figment = { version = "0.10", features = ["toml", "env"] } | ||
| miden-lib = { workspace = true } | ||
| miden-client = { version = "0.1.0", features = ["concurrent"] } | ||
| miden-node-proto = { path = "../proto", version = "0.2" } | ||
| miden-node-utils = { path = "../utils", version = "0.2" } | ||
| miden-objects = { workspace = true } | ||
| serde = { version = "1.0", features = ["derive"] } | ||
| clap = { version = "4.5.1", features = ["derive"] } | ||
| async-mutex = "1.4.0" | ||
| tracing = { workspace = true } | ||
| tracing-subscriber = { workspace = true } |
There was a problem hiding this comment.
nit: let's alphabetize the dependencies.
bobbinth
pushed a commit
that referenced
this pull request
Apr 12, 2024
* ci: turn doc warnings into errors (#259) * Boilerplate done * pushed fix for miden-client * Fix formatting * Pulled after client fix * Fixed typos + added build_client fn * Added configs + figment * Fix client implementation in faucet + use released client * updated cargo * Fixed Miden node when importing Miden client, db errors * Format files * Added proper support of configuration file + logging * Improved config file handling * Removed superfluous file * First pass at improvements * Change naming of note * Fixed html + added metadata endpoint * Want to implement Display for NoteId * Upgraded js to use async + NoteId does not impl Display in main * cargo updated --------- Co-authored-by: Augusto Hack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Miden node generates 2 accounts by default at genesis:
We need to make the faucet available and usable on node spin-up, this would enable request of funds and testing of tx's from users of the network.
In this PR I propose to add a new crate called
faucetto the nodeworkspaceand useactix-webto create a web-server that will servehtml,cssandjsstatic files.The faucet receives requests of funds through an endpoint where users on the frontend pass their AccountId. The server responds with the note generated by the tx. The end user is then able to import this newly received note into their client and consume it locally.
closes: #215