Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate CI into multiple files #278

Merged
merged 13 commits into from
Mar 15, 2024
Merged

Separate CI into multiple files #278

merged 13 commits into from
Mar 15, 2024

Conversation

phklive
Copy link
Contributor

@phklive phklive commented Mar 14, 2024

In this PR I propose the separation of the CI jobs into multiple files enabling more scaling and better separation of concerns.

closes: #268

Copy link
Contributor

@polydez polydez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! How about running these tasks not only for main, but also for next branch?

@bobbinth
Copy link
Contributor

Question: how would this affect the CI badge that we have in the main readme file (see here).

@phklive
Copy link
Contributor Author

phklive commented Mar 15, 2024

Question: how would this affect the CI badge that we have in the main readme file (see here).

Changed the badge from CI to UNIT test to make sure it is still relevant.

In the future we can or:

  • Remove the badge
  • Add more badges ( lint, doc, docker, ... )

Fun fact, hovered around the reth codebase and saw that their badge was also broken haha: paradigmxyz/reth#7158

@bobbinth
Copy link
Contributor

Changed the badge from CI to UNIT test to make sure it is still relevant.

Is there a way to change the label on the badge to tests?

Not sure if we need to add lint and doc badges - but maybe some others would be interesting in the future (e.g., docker could be interesting). But I do think tests we should keep for sure.

@phklive
Copy link
Contributor Author

phklive commented Mar 15, 2024

Changed the badge from CI to UNIT test to make sure it is still relevant.

Is there a way to change the label on the badge to tests?

Not sure if we need to add lint and doc badges - but maybe some others would be interesting in the future (e.g., docker could be interesting). But I do think tests we should keep for sure.

Changed it to test to keep naming convention with the other files being singular.

@phklive phklive merged commit ce6effc into next Mar 15, 2024
5 checks passed
@phklive phklive deleted the phklive-separate-ci branch March 15, 2024 17:04
bobbinth pushed a commit that referenced this pull request Apr 12, 2024
* ci: turn doc warnings into errors (#259)

* Separated different CI jobs in their respective files

* Add next branch in ci

* Fix wrong naming in CI + use cargo make for doc

* Fixed badge + removed unnecessary additional file

* Change naming of ci and jobs

* Fix naming

* Fix comment

---------

Co-authored-by: Augusto Hack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants