-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate CI into multiple files #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! How about running these tasks not only for main
, but also for next
branch?
Question: how would this affect the CI badge that we have in the main readme file (see here). |
Changed the badge from CI to UNIT test to make sure it is still relevant. In the future we can or:
Fun fact, hovered around the reth codebase and saw that their badge was also broken haha: paradigmxyz/reth#7158 |
Is there a way to change the label on the badge to Not sure if we need to add lint and doc badges - but maybe some others would be interesting in the future (e.g., |
Changed it to |
* ci: turn doc warnings into errors (#259) * Separated different CI jobs in their respective files * Add next branch in ci * Fix wrong naming in CI + use cargo make for doc * Fixed badge + removed unnecessary additional file * Change naming of ci and jobs * Fix naming * Fix comment --------- Co-authored-by: Augusto Hack <[email protected]>
In this PR I propose the separation of the CI jobs into multiple files enabling more scaling and better separation of concerns.
closes: #268