-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end-to-end testing workflow #282
Closed
Closed
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f3e68f6
chore: update crate versions to v0.2.0
bobbinth 5c79ccb
Add script to check rust versions + cleanup (#272)
phklive 2e66d45
Dockerize node (#257)
phklive 95d3fff
Implemented nullifier tree wrapper over `Smt` (#275)
polydez ce6effc
Separate CI into multiple files (#278)
phklive c7791d0
Boilerplate
phklive b2e946a
refactor: small error refactoring (using `'static str` instead of `St…
polydez e26d69c
Added end to end workflow
phklive d9b7aef
merge next
phklive 20ab098
First end to end test
phklive 78d4cab
Cleanup + remove rm store
phklive efbd3f4
fix gitignore
phklive fd1f40d
add comments
phklive dc88ee1
bugfix: table name is block_headers instead of block_header (#283)
hackaugusto 9975495
sqlite: use bundled version to enable FK checks (#284)
hackaugusto 989f403
Merge branch 'next' into phklive-end-to-end
phklive 98f704e
cargo update
phklive 121c86c
chore: update CI action for rust install (#280)
mFragaBA d8edb09
Add faucet enabling testing (#270)
phklive dee355f
Merge branch 'next' into phklive-end-to-end
phklive 0b073db
cargo updated
phklive 8113178
Improved bash scripts + changed naming in CI
phklive fdd5f0b
Fixing cargo.lock conflicts + merging next
phklive File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# Include any files or directories that you don't want to be copied to your | ||
# container here (e.g., local build artifacts, temporary files, etc.). | ||
# | ||
# For more help, visit the .dockerignore file reference guide at | ||
# https://docs.docker.com/go/build-context-dockerignore/ | ||
|
||
**/.DS_Store | ||
**/.classpath | ||
**/.dockerignore | ||
**/.env | ||
**/.git | ||
**/.gitignore | ||
**/.project | ||
**/.settings | ||
**/.toolstarget | ||
**/.vs | ||
**/.vscode | ||
**/*.*proj.user | ||
**/*.dbmdl | ||
**/*.jfm | ||
**/charts | ||
**/docker-compose* | ||
**/compose* | ||
**/Dockerfile* | ||
**/node_modules | ||
**/npm-debug.log | ||
**/secrets.dev.yaml | ||
**/values.dev.yaml | ||
./bin | ||
./target | ||
/bin | ||
/target | ||
LICENSE | ||
README.md | ||
accounts | ||
genesis.dat | ||
miden-store.* | ||
store.* |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Runs documentation related jobs. | ||
|
||
name: doc | ||
|
||
on: | ||
push: | ||
branches: [main, next] | ||
pull_request: | ||
types: [opened, reopened, synchronize] | ||
|
||
jobs: | ||
doc: | ||
name: doc stable on ubuntu-latest | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Install Rust | ||
uses: dtolnay/rust-toolchain@stable | ||
- name: Install cargo make | ||
run: cargo install cargo-make | ||
- name: cargo make - doc | ||
run: cargo make doc |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# Runs linting related jobs. | ||
|
||
name: lint | ||
|
||
on: | ||
push: | ||
branches: [main, next] | ||
pull_request: | ||
types: [opened, reopened, synchronize] | ||
|
||
jobs: | ||
version: | ||
name: check rust version consistency | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
profile: minimal | ||
override: true | ||
- name: check rust versions | ||
run: ./scripts/check-rust-version.sh | ||
|
||
rustfmt: | ||
name: rustfmt nightly on ubuntu-latest | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Install minimal Rust with rustfmt | ||
uses: dtolnay/rust-toolchain@master | ||
with: | ||
toolchain: nightly | ||
components: rustfmt | ||
- name: Install cargo make | ||
run: cargo install cargo-make | ||
- name: cargo make - format-check | ||
run: cargo make format-check | ||
|
||
clippy: | ||
name: clippy stable on ubuntu-latest | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Install minimal Rust with clippy | ||
uses: dtolnay/rust-toolchain@master | ||
with: | ||
toolchain: stable | ||
components: clippy | ||
- name: Install cargo make | ||
run: cargo install cargo-make | ||
- name: cargo make - clippy | ||
run: cargo make clippy |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
# Runs testing related jobs. | ||
|
||
name: test | ||
|
||
on: | ||
push: | ||
branches: [main, next] | ||
pull_request: | ||
types: [opened, reopened, synchronize] | ||
|
||
jobs: | ||
unit-and-integration: | ||
name: test stable on ubuntu-latest | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 30 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Install Rust | ||
uses: dtolnay/rust-toolchain@stable | ||
- name: Install cargo make | ||
run: cargo install cargo-make | ||
- name: cargo make - test | ||
run: cargo make test | ||
|
||
end-to-end: | ||
name: end-to-end tests stable on ubuntu-latest | ||
runs-on: ubuntu-latest | ||
timeout-minutes: 30 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Install Rust | ||
uses: actions-rs/toolchain@v1 | ||
with: | ||
profile: minimal | ||
override: true | ||
- name: Install cargo make | ||
run: cargo install cargo-make | ||
- name: cargo make - docker-build-node | ||
run: cargo make docker-build-node | ||
- name: cargo make - docker-run-node | ||
run: cargo make docker-run-node | ||
- name: cargo install - miden-client | ||
run: cargo install miden-client --features concurrent,testing | ||
- name: cargo make - test-end-to-end | ||
run: cargo make test-end-to-end | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: is the docker image built with
concurrent,testing
by default? Should we specify these features explicilty?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed the docker image is built with the
concurrent,testing
features enabled by default.Could you clarify by specify these features explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On line 46 we explicitly build
miden-client
withconcurrent,testing
features. Could we do something similar on line 42?The main motivation is to make sure that that changing the defaults for docker build does not break this task.