Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate code to the latest miden-base #559

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Conversation

polydez
Copy link
Contributor

@polydez polydez commented Dec 2, 2024

Removed unused dependencies, updated errors, fixed compilation errors in order to make node compilable against latest miden-base.

Copy link

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really familiar with the node, but the error and test changes look good!

Comment on lines 419 to 421
assert!(
matches!(account_read.storage().get_item(3), Ok(digest) if digest == RpoDigest::default())
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could be assert_matches! instead.

@polydez polydez merged commit a686581 into next Dec 2, 2024
8 checks passed
@polydez polydez deleted the polydez-latest-base branch December 2, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants