Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing links between public values #1206

Merged

Conversation

LindaGuiga
Copy link
Contributor

This PR aims at implementing the missing public value links, especially for public values introduced by the receipts and logs PR:

  • It applies reads for the transaction numbers, the cumulative gas used and block bloom filters (before and after the current transaction).
  • It initializes block bloom filters (it creates a segment for the block bloom filters instead of using GlobalMetadata, to avoid code duplication, since each bloom filter is comprised of eight 32-bits words).
  • It adds links in aggregation and block proofs for cum_gas_used, txn_number and block_filters.
  • It also links state trie roots between block proofs and ensures that transaction and receipt tries are empty at the beginning of a block.

Please let me know if there's anything I missed, or any suggestions/corrections!

Copy link
Contributor

@wborgeaud wborgeaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

evm/src/fixed_recursive_verifier.rs Outdated Show resolved Hide resolved
evm/src/fixed_recursive_verifier.rs Outdated Show resolved Hide resolved
evm/src/fixed_recursive_verifier.rs Outdated Show resolved Hide resolved
evm/src/fixed_recursive_verifier.rs Show resolved Hide resolved
evm/src/fixed_recursive_verifier.rs Outdated Show resolved Hide resolved
evm/src/fixed_recursive_verifier.rs Outdated Show resolved Hide resolved
@LindaGuiga LindaGuiga merged commit 6207f44 into 0xPolygonZero:main Sep 6, 2023
2 checks passed
@Nashtare Nashtare deleted the missing-public-value-links branch September 6, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants