Add random value to block metadata and fix sys_prevrandao
#1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
reviewed
Sep 6, 2023
LindaGuiga
reviewed
Sep 20, 2023
There was a problem hiding this comment.
Should sys_prevrandao be removed from syscall_stubs.asm and put in (for example) metadata.asm instead?
| @@ -336,6 +346,9 @@ impl BlockMetadataTarget { | |||
| builder.connect(bm0.block_timestamp, bm1.block_timestamp); | |||
| builder.connect(bm0.block_number, bm1.block_number); | |||
| builder.connect(bm0.block_difficulty, bm1.block_difficulty); | |||
| for i in 0..8 { | |||
| builder.connect(bm0.block_random[i], bm1.block_random[i]); | |||
There was a problem hiding this comment.
block_random is connected here, but it isn't set in set_block_metadata_target. This leads to a generators not run error in a recursive proof.
| @@ -10,11 +10,9 @@ global sys_blockhash: | |||
| EXIT_KERNEL | |||
|
|
|||
| // This is a temporary version that returns the block difficulty (i.e. the old version of this opcode). | |||
There was a problem hiding this comment.
Shouldn't this comment be deleted or updated?
# Conflicts: # evm/src/cpu/kernel/constants/global_metadata.rs # evm/src/get_challenges.rs # evm/src/proof.rs # evm/src/recursive_verifier.rs
Nashtare
approved these changes
Sep 25, 2023
evm/tests/log_opcode.rs
Outdated
| @@ -791,6 +793,7 @@ fn test_two_txn() -> anyhow::Result<()> { | |||
| block_timestamp: 0x03e8.into(), | |||
| block_number: 1.into(), | |||
| block_difficulty: 0x020000.into(), | |||
| block_random: H256::from_low_u64_le(0x020000), | |||
There was a problem hiding this comment.
tiny nit: we're using H256::from_uint(n.into()) in other places, though doesn't really matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1204 for details.