Add blockhash opcode #1208
Merged
Add blockhash opcode #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborgeaud
approved these changes
Sep 4, 2023
| // stack: cur_block_number, block_number, retdest | ||
| DUP1 DUP3 %increment GT %jumpi(zero_hash) // if block_number >= cur_block_number | ||
| // stack: cur_block_number, block_number, retdest | ||
| DUP2 PUSH 256 ADD |
There was a problem hiding this comment.
This should be an addition with an overflow check.
There was a problem hiding this comment.
As mentioned in the following comments, I left this as is and added the overflow check on block_number directly.
wborgeaud
reviewed
Sep 5, 2023
LindaGuiga
force-pushed
the
blockhash_opcode
branch
from
f7a9157 to
9a06fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the BLOCKHASH opcode, following @wborgeaud's second suggestion in this issue. It includes links between proofs, a couple of unit tests and the challenger observing the additional public values (the previous and current block hashes).
closes #1173