Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement serde Serialize and Deserialize for Target #1214

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

jtguibas
Copy link
Contributor

@jtguibas jtguibas commented Sep 6, 2023

This PR adds support for adding the Serialize and Deserialize macro to targets. It addresses issue #1197.

Implementing automatic serialization/deserialization allows for types composed of targets to also support serde serialization/deserialization. This means that a lot of the manual code written to serialize generator structs can be fully automated with serde.

@jtguibas jtguibas changed the title feat: implement serde Serialize and Deserialize for Targets feat: implement serde Serialize and Deserialize for Target Sep 6, 2023
@jtguibas jtguibas changed the title feat: implement serde Serialize and Deserialize for Target feat: implement serde Serialize and Deserialize for Target/PrimeField64 Sep 6, 2023
@jtguibas jtguibas force-pushed the jtguibas/serde-target branch from 3256dc5 to 800603d Compare September 6, 2023 16:45
@jtguibas jtguibas changed the title feat: implement serde Serialize and Deserialize for Target/PrimeField64 feat: implement serde Serialize and Deserialize for Target Sep 6, 2023
Copy link
Contributor

@dlubarov dlubarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npwardberkeley npwardberkeley merged commit e6ca460 into 0xPolygonZero:main Sep 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants