Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's one compiler error that's preventing us from building on the latest nightly, and I managed to resolve it by making a paremeter into a reference. I tried a few other things before resorting to using a reference (like
#![feature(const_precise_live_drops)]
), but I couldn't get it to compile. I think using a reference here should have no performance changes (since it's still aconst fn
at the end of the day), but let me know if there's a better way to fix this error.For reference, the error was this:
Resolves #1186.