Make next row available to CTLs #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Co-authored-by: Nicholas Ward <[email protected]>
npwardberkeley
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. the Related work section of #1149.
When declaring a CTL, we can now access both
lvandnv. For ease of implementation, allnvcolumns are declared after thelvcolumns. This PR does not bring anything concrete since no CTL needs it, but it paves the way to future optimizations.In term of implementation details, the only thing of note is that the CTL Z polynomials are upside down, with the full product in the first row and the initial value in the last row. This allows us to compute the transition constraint while only using values from
lvandnv(previously, we would have needed values from the row afternv).