Transactions trie support #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
force-pushed
the
transactions
branch
from
0125fdd to
b1d5bfd
Compare
Nashtare
reviewed
Sep 13, 2023
| @@ -119,7 +127,7 @@ fn test_receipt_encoding() -> Result<()> { | |||
| // Get the expected RLP encoding. | |||
| let expected_rlp = rlp::encode(&rlp::encode(&receipt_1)); | |||
|
|
|||
| let initial_stack = vec![retdest, 0.into(), 0.into()]; | |||
| let initial_stack: Vec<U256> = vec![retdest, 0.into(), 0.into()]; | |||
There was a problem hiding this comment.
Those changes seem unnecessary, but they silenced the clippy warning of needless vec (which is actually needed because of the Interpreter::new_with_kernel expected parameter types).
Nashtare
force-pushed
the
transactions
branch
from
71f02cc to
cb27a84
Compare
|
@wborgeaud Sorry for the force-push, the history got completely messed up during a rebase, and induced an error in one of the tests which was easier to just revert to the state of your review (commit fa63f90), and then do a clean merge followed by applying your comments. |
|
No worries, still looks good 👍 |
Nashtare
added a commit
to topos-protocol/plonky2
that referenced
this pull request
Nov 30, 2023
This reverts commit f49fbc8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the transaction trie with the processed transactions.
The transaction trie update is done as follows:
After reading and decoding each transaction from the prover inputs we copy the txn rlp and its size to the trie data segment. The pointer to this data is then used as payload for inserting a node with key RLP(txn_counter) in the transaction trie.
For hashing the transaction trie we implemented the function encode_txn. This function simply copies the rlp encoded transaction to the address received as input