Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine mload_32bytes and mstore_32bytes flags #1252

Closed
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add comment for ctl_data_byte32
  • Loading branch information
LindaGuiga committed Nov 9, 2023
commit 1933143e45ca6d683017c650a3ff946383aafdeb
4 changes: 4 additions & 0 deletions evm/src/cpu/cpu_stark.rs
Original file line number Diff line number Diff line change
@@ -125,6 +125,10 @@ pub fn ctl_arithmetic_shift_rows<F: Field>() -> TableWithColumns<F> {
TableWithColumns::new(Table::Cpu, columns, Some(Column::single(COL_MAP.op.shift)))
}

/// We use the same columns for `memop_32bytes` and `is_keccak_sponge`.
/// However, while `MLOAD_32BYTES` and `KeccakSponge` share the same
/// data structure for the memory columns, MSTORE_32BYTES reads from
/// GP channel 4, instead of pushing into it.
pub fn ctl_data_byte32<F: Field>() -> Vec<Column<F>> {
ctl_data_keccak_sponge()
}