Fix shift constraint #1280
Merged
Fix shift constraint #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the shift constraints for displacement >$2^{32}$ .
The issue is that when calling
append_shiftinwitness/operations.rs, we don't perform a READ if the displacement does not fit in the lowest limb, but this isn't properly represented in constraints.We also didn't compute the general column for the inverse of the high_limbs_sum, which is necessary for satisfying some of the constraints.
I've also added constraint comments on the recursive side for easy reading and consistency with how the other modules are documented.
@unzvfu Would you mind confirming?