Add journal entry for logs #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborgeaud
approved these changes
Oct 11, 2023
evm/src/cpu/kernel/asm/core/log.asm
Outdated
Comment on lines
269
to
286
| %macro journal_add_log | ||
| %journal_add_2(@JOURNAL_ENTRY_LOG) | ||
| %endmacro | ||
|
|
||
| global revert_log: | ||
| // stack: entry_type, ptr, retdest | ||
| POP | ||
| // First, reduce the number of logs. | ||
| %mload_global_metadata(@GLOBAL_METADATA_LOGS_LEN) | ||
| %decrement | ||
| %mstore_global_metadata(@GLOBAL_METADATA_LOGS_LEN) | ||
| // stack: ptr, retdest | ||
| // Second, restore payload length. | ||
| %journal_load_2 | ||
| // stack: prev_logs_data_len, prev_payload_len, retdest | ||
| %mstore_global_metadata(@GLOBAL_METADATA_LOGS_DATA_LEN) | ||
| %mstore_global_metadata(@GLOBAL_METADATA_LOGS_PAYLOAD_LEN) | ||
| JUMP |
There was a problem hiding this comment.
nit: For other journal entries, we have a file evm/src/cpu/kernel/asm/journal/X.asm containing journal_add_X and revert_X. So maybe we can add a evm/src/cpu/kernel/asm/journal/log.asm with this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed a few tests failing, such as
logInOOG_Calldue to logs happening within a CALL, and not reverting. To fix this, this PR adds logs to the journal so they can be reverted when necessary.