Remerge context flags #1292
Merged
Remerge context flags #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LindaGuiga
reviewed
Oct 27, 2023
| @@ -318,7 +318,22 @@ pub(crate) fn generate_get_context<F: Field>( | |||
| state: &mut GenerationState<F>, | |||
| mut row: CpuColumnsView<F>, | |||
| ) -> Result<(), ProgramError> { | |||
| push_with_write(state, &mut row, state.registers.context.into())?; | |||
| // Same logic as push_with_write, but we have to use channel 3 for stack constraint reasons. | |||
There was a problem hiding this comment.
Actually, since we are no longer storing the top of the stack in channel 4 (I think that was the reason), can't we use channel 4 both here and for the constraints now?
There was a problem hiding this comment.
That's true, though it will have to be 3 after #1291 is merged. We might as well leave it as is.
|
Kudos, SonarCloud Quality Gate passed!
|
LindaGuiga
approved these changes
Oct 30, 2023
pgebheim
modified the milestones:
v0.1.0-rc2 - Optimizations / Documentation,
v0.1.0-rc1 - VM Audit Readiness / Bugfixes
wborgeaud
added a commit
that referenced
this pull request
Nov 3, 2023
* Add SMT types * Progress * Progress * Working smt hashing * Minor * Fix hash * Working insert * Minor * Add insert test for storage trie * Add missing constraints for DUP/SWAP (#1310) * Refactor wcopy syscalls * Refactor memcpy * Working test_simple_transfer * Modify add11_yml.rs * Refactor codecopy * Fix * Fix calldatacopy * Fix test on interpreter side * Remove new_stack_top_channel from StackBehavior (#1296) * Working add11_yml.rs * All tests compile * Working test_balance * Minor * Working test_extcodesize * All non-ignored tests pass * Fix test_empty_txn_list * Clippy * smt_utils point to github * Comments * Fix kexit_info in test * Review * Update Cargo.toml * Move empty check inside final iteration * Remerge context flags (#1292) * Remerge context flags * Apply comments and revert some unwanted changes * Merge NOT and POP flags. (#1257) * Merge NOT and POP flags * Add comments * Disable remaining memory channels for POP * Apply comments * Fix stack * More of memcpy_bytes * Add some documentation in EVM crate (#1295) Co-authored-by: Linda Guiga <[email protected]> * Combine PUSH0 and PC flags. (#1256) * PR feedback * Add context constraints (#1260) * Combine JUMPDEST and KECCAK_GENERAL flags. (#1259) * Combine JUMPDEST and KECCAK_GENERAL flags. * Apply comments * Fix merging of jumpdest and keccak_general. * Add test for selfdestruct (#1321) * Add test for selfdestruct * Comment * Fix test --------- Co-authored-by: Hamy Ratoanina <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Linda Guiga <[email protected]>
pgebheim
added a commit
that referenced
this pull request
Nov 3, 2023
commit 4f854e6 Author: wborgeaud <[email protected]> Date: Fri Nov 3 13:48:23 2023 +0100 Minor commit fbd4c78 Merge: ad580c2 c70a785 Author: wborgeaud <[email protected]> Date: Fri Nov 3 13:42:45 2023 +0100 Merge branch 'feat/type2' into type2/smt_deletion # Conflicts: # evm/src/cpu/kernel/aggregator.rs # evm/src/cpu/kernel/asm/mpt/storage/storage_write.asm # evm/src/cpu/kernel/asm/smt/insert.asm # evm/src/cpu/kernel/asm/smt/utils.asm # evm/src/cpu/kernel/constants/mod.rs # evm/src/cpu/kernel/tests/smt/mod.rs # evm/tests/selfdestruct.rs commit c70a785 Author: wborgeaud <[email protected]> Date: Fri Nov 3 13:37:19 2023 +0100 Start of SMT implementation for Type 2 zkEVM (#1315) * Add SMT types * Progress * Progress * Working smt hashing * Minor * Fix hash * Working insert * Minor * Add insert test for storage trie * Add missing constraints for DUP/SWAP (#1310) * Refactor wcopy syscalls * Refactor memcpy * Working test_simple_transfer * Modify add11_yml.rs * Refactor codecopy * Fix * Fix calldatacopy * Fix test on interpreter side * Remove new_stack_top_channel from StackBehavior (#1296) * Working add11_yml.rs * All tests compile * Working test_balance * Minor * Working test_extcodesize * All non-ignored tests pass * Fix test_empty_txn_list * Clippy * smt_utils point to github * Comments * Fix kexit_info in test * Review * Update Cargo.toml * Move empty check inside final iteration * Remerge context flags (#1292) * Remerge context flags * Apply comments and revert some unwanted changes * Merge NOT and POP flags. (#1257) * Merge NOT and POP flags * Add comments * Disable remaining memory channels for POP * Apply comments * Fix stack * More of memcpy_bytes * Add some documentation in EVM crate (#1295) Co-authored-by: Linda Guiga <[email protected]> * Combine PUSH0 and PC flags. (#1256) * PR feedback * Add context constraints (#1260) * Combine JUMPDEST and KECCAK_GENERAL flags. (#1259) * Combine JUMPDEST and KECCAK_GENERAL flags. * Apply comments * Fix merging of jumpdest and keccak_general. * Add test for selfdestruct (#1321) * Add test for selfdestruct * Comment * Fix test --------- Co-authored-by: Hamy Ratoanina <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Linda Guiga <[email protected]> commit ad580c2 Author: wborgeaud <[email protected]> Date: Thu Nov 2 08:40:46 2023 +0100 Clippy commit fe5b8fd Author: wborgeaud <[email protected]> Date: Thu Nov 2 08:39:26 2023 +0100 s/mpt/smt in a bunch of places commit 73dc262 Author: wborgeaud <[email protected]> Date: Thu Nov 2 08:15:56 2023 +0100 Selfdestruct test passes commit 539190f Merge: e110941 f71f227 Author: wborgeaud <[email protected]> Date: Thu Nov 2 07:58:15 2023 +0100 Merge branch 'main' into type2/smt_deletion commit e110941 Author: wborgeaud <[email protected]> Date: Wed Nov 1 17:04:38 2023 +0100 Minor commit f7fba35 Author: wborgeaud <[email protected]> Date: Wed Nov 1 12:24:13 2023 +0100 PR feedback commit e528b89 Author: wborgeaud <[email protected]> Date: Mon Oct 30 09:11:25 2023 +0100 Update Cargo.toml commit 5eaf83e Author: wborgeaud <[email protected]> Date: Fri Oct 27 12:34:52 2023 +0200 Comments commit ae9c443 Author: wborgeaud <[email protected]> Date: Fri Oct 27 11:51:16 2023 +0200 smt_utils point to github commit b3d61b7 Author: wborgeaud <[email protected]> Date: Fri Oct 27 11:49:33 2023 +0200 Clippy commit ccb3d7e Author: wborgeaud <[email protected]> Date: Fri Oct 27 10:00:20 2023 +0200 Fix test_empty_txn_list commit 986b010 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:48:14 2023 +0200 All non-ignored tests pass commit 7bb0c02 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:44:40 2023 +0200 Working test_extcodesize commit b8a85d4 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:38:08 2023 +0200 Minor commit 2c01b05 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:37:05 2023 +0200 Working test_balance commit e370b62 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:13:36 2023 +0200 All tests compile commit f21bc5c Author: wborgeaud <[email protected]> Date: Fri Oct 27 08:31:04 2023 +0200 Working add11_yml.rs commit 4e2b3f3 Author: wborgeaud <[email protected]> Date: Thu Oct 26 18:50:32 2023 +0200 Modify add11_yml.rs commit c324412 Author: wborgeaud <[email protected]> Date: Thu Oct 26 18:28:21 2023 +0200 Working test_simple_transfer commit df55e45 Author: wborgeaud <[email protected]> Date: Thu Oct 26 08:54:24 2023 +0200 Add insert test for storage trie commit ca0102f Author: wborgeaud <[email protected]> Date: Thu Oct 26 08:42:03 2023 +0200 Minor commit dc27351 Author: wborgeaud <[email protected]> Date: Thu Oct 26 08:40:57 2023 +0200 Working insert commit f6c4067 Author: wborgeaud <[email protected]> Date: Wed Oct 25 08:07:31 2023 +0200 Fix hash commit c6e85eb Author: wborgeaud <[email protected]> Date: Wed Oct 18 18:46:32 2023 +0200 Minor commit d95c430 Author: wborgeaud <[email protected]> Date: Wed Oct 18 18:32:05 2023 +0200 Working smt hashing commit fd09915 Author: wborgeaud <[email protected]> Date: Wed Oct 18 14:32:38 2023 +0200 Progress commit a706cda Author: wborgeaud <[email protected]> Date: Wed Oct 18 07:37:26 2023 +0200 Progress commit 95e5cc1 Author: wborgeaud <[email protected]> Date: Fri Oct 13 09:19:45 2023 +0200 Add SMT types
LindaGuiga
added a commit
to topos-protocol/plonky2
that referenced
this pull request
Nov 3, 2023
* Add SMT types * Progress * Progress * Working smt hashing * Minor * Fix hash * Working insert * Minor * Add insert test for storage trie * Add missing constraints for DUP/SWAP (0xPolygonZero#1310) * Refactor wcopy syscalls * Refactor memcpy * Working test_simple_transfer * Modify add11_yml.rs * Refactor codecopy * Fix * Fix calldatacopy * Fix test on interpreter side * Remove new_stack_top_channel from StackBehavior (0xPolygonZero#1296) * Working add11_yml.rs * All tests compile * Working test_balance * Minor * Working test_extcodesize * All non-ignored tests pass * Fix test_empty_txn_list * Clippy * smt_utils point to github * Comments * Fix kexit_info in test * Review * Update Cargo.toml * Move empty check inside final iteration * Remerge context flags (0xPolygonZero#1292) * Remerge context flags * Apply comments and revert some unwanted changes * Merge NOT and POP flags. (0xPolygonZero#1257) * Merge NOT and POP flags * Add comments * Disable remaining memory channels for POP * Apply comments * Fix stack * More of memcpy_bytes * Add some documentation in EVM crate (0xPolygonZero#1295) Co-authored-by: Linda Guiga <[email protected]> * Combine PUSH0 and PC flags. (0xPolygonZero#1256) * PR feedback * Add context constraints (0xPolygonZero#1260) * Combine JUMPDEST and KECCAK_GENERAL flags. (0xPolygonZero#1259) * Combine JUMPDEST and KECCAK_GENERAL flags. * Apply comments * Fix merging of jumpdest and keccak_general. * Add test for selfdestruct (0xPolygonZero#1321) * Add test for selfdestruct * Comment * Fix test --------- Co-authored-by: Hamy Ratoanina <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Linda Guiga <[email protected]>
wborgeaud
added a commit
that referenced
this pull request
Nov 14, 2023
commit 4f854e6 Author: wborgeaud <[email protected]> Date: Fri Nov 3 13:48:23 2023 +0100 Minor commit fbd4c78 Merge: ad580c2 c70a785 Author: wborgeaud <[email protected]> Date: Fri Nov 3 13:42:45 2023 +0100 Merge branch 'feat/type2' into type2/smt_deletion # Conflicts: # evm/src/cpu/kernel/aggregator.rs # evm/src/cpu/kernel/asm/mpt/storage/storage_write.asm # evm/src/cpu/kernel/asm/smt/insert.asm # evm/src/cpu/kernel/asm/smt/utils.asm # evm/src/cpu/kernel/constants/mod.rs # evm/src/cpu/kernel/tests/smt/mod.rs # evm/tests/selfdestruct.rs commit c70a785 Author: wborgeaud <[email protected]> Date: Fri Nov 3 13:37:19 2023 +0100 Start of SMT implementation for Type 2 zkEVM (#1315) * Add SMT types * Progress * Progress * Working smt hashing * Minor * Fix hash * Working insert * Minor * Add insert test for storage trie * Add missing constraints for DUP/SWAP (#1310) * Refactor wcopy syscalls * Refactor memcpy * Working test_simple_transfer * Modify add11_yml.rs * Refactor codecopy * Fix * Fix calldatacopy * Fix test on interpreter side * Remove new_stack_top_channel from StackBehavior (#1296) * Working add11_yml.rs * All tests compile * Working test_balance * Minor * Working test_extcodesize * All non-ignored tests pass * Fix test_empty_txn_list * Clippy * smt_utils point to github * Comments * Fix kexit_info in test * Review * Update Cargo.toml * Move empty check inside final iteration * Remerge context flags (#1292) * Remerge context flags * Apply comments and revert some unwanted changes * Merge NOT and POP flags. (#1257) * Merge NOT and POP flags * Add comments * Disable remaining memory channels for POP * Apply comments * Fix stack * More of memcpy_bytes * Add some documentation in EVM crate (#1295) Co-authored-by: Linda Guiga <[email protected]> * Combine PUSH0 and PC flags. (#1256) * PR feedback * Add context constraints (#1260) * Combine JUMPDEST and KECCAK_GENERAL flags. (#1259) * Combine JUMPDEST and KECCAK_GENERAL flags. * Apply comments * Fix merging of jumpdest and keccak_general. * Add test for selfdestruct (#1321) * Add test for selfdestruct * Comment * Fix test --------- Co-authored-by: Hamy Ratoanina <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Linda Guiga <[email protected]> commit ad580c2 Author: wborgeaud <[email protected]> Date: Thu Nov 2 08:40:46 2023 +0100 Clippy commit fe5b8fd Author: wborgeaud <[email protected]> Date: Thu Nov 2 08:39:26 2023 +0100 s/mpt/smt in a bunch of places commit 73dc262 Author: wborgeaud <[email protected]> Date: Thu Nov 2 08:15:56 2023 +0100 Selfdestruct test passes commit 539190f Merge: e110941 f71f227 Author: wborgeaud <[email protected]> Date: Thu Nov 2 07:58:15 2023 +0100 Merge branch 'main' into type2/smt_deletion commit e110941 Author: wborgeaud <[email protected]> Date: Wed Nov 1 17:04:38 2023 +0100 Minor commit f7fba35 Author: wborgeaud <[email protected]> Date: Wed Nov 1 12:24:13 2023 +0100 PR feedback commit e528b89 Author: wborgeaud <[email protected]> Date: Mon Oct 30 09:11:25 2023 +0100 Update Cargo.toml commit 5eaf83e Author: wborgeaud <[email protected]> Date: Fri Oct 27 12:34:52 2023 +0200 Comments commit ae9c443 Author: wborgeaud <[email protected]> Date: Fri Oct 27 11:51:16 2023 +0200 smt_utils point to github commit b3d61b7 Author: wborgeaud <[email protected]> Date: Fri Oct 27 11:49:33 2023 +0200 Clippy commit ccb3d7e Author: wborgeaud <[email protected]> Date: Fri Oct 27 10:00:20 2023 +0200 Fix test_empty_txn_list commit 986b010 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:48:14 2023 +0200 All non-ignored tests pass commit 7bb0c02 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:44:40 2023 +0200 Working test_extcodesize commit b8a85d4 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:38:08 2023 +0200 Minor commit 2c01b05 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:37:05 2023 +0200 Working test_balance commit e370b62 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:13:36 2023 +0200 All tests compile commit f21bc5c Author: wborgeaud <[email protected]> Date: Fri Oct 27 08:31:04 2023 +0200 Working add11_yml.rs commit 4e2b3f3 Author: wborgeaud <[email protected]> Date: Thu Oct 26 18:50:32 2023 +0200 Modify add11_yml.rs commit c324412 Author: wborgeaud <[email protected]> Date: Thu Oct 26 18:28:21 2023 +0200 Working test_simple_transfer commit df55e45 Author: wborgeaud <[email protected]> Date: Thu Oct 26 08:54:24 2023 +0200 Add insert test for storage trie commit ca0102f Author: wborgeaud <[email protected]> Date: Thu Oct 26 08:42:03 2023 +0200 Minor commit dc27351 Author: wborgeaud <[email protected]> Date: Thu Oct 26 08:40:57 2023 +0200 Working insert commit f6c4067 Author: wborgeaud <[email protected]> Date: Wed Oct 25 08:07:31 2023 +0200 Fix hash commit c6e85eb Author: wborgeaud <[email protected]> Date: Wed Oct 18 18:46:32 2023 +0200 Minor commit d95c430 Author: wborgeaud <[email protected]> Date: Wed Oct 18 18:32:05 2023 +0200 Working smt hashing commit fd09915 Author: wborgeaud <[email protected]> Date: Wed Oct 18 14:32:38 2023 +0200 Progress commit a706cda Author: wborgeaud <[email protected]> Date: Wed Oct 18 07:37:26 2023 +0200 Progress commit 95e5cc1 Author: wborgeaud <[email protected]> Date: Fri Oct 13 09:19:45 2023 +0200 Add SMT types Co-authored-by: Paul Gebheim <[email protected]>
pgebheim
added a commit
that referenced
this pull request
Nov 27, 2023
* Squashed commit of the following: commit 4f854e6 Author: wborgeaud <[email protected]> Date: Fri Nov 3 13:48:23 2023 +0100 Minor commit fbd4c78 Merge: ad580c2 c70a785 Author: wborgeaud <[email protected]> Date: Fri Nov 3 13:42:45 2023 +0100 Merge branch 'feat/type2' into type2/smt_deletion # Conflicts: # evm/src/cpu/kernel/aggregator.rs # evm/src/cpu/kernel/asm/mpt/storage/storage_write.asm # evm/src/cpu/kernel/asm/smt/insert.asm # evm/src/cpu/kernel/asm/smt/utils.asm # evm/src/cpu/kernel/constants/mod.rs # evm/src/cpu/kernel/tests/smt/mod.rs # evm/tests/selfdestruct.rs commit c70a785 Author: wborgeaud <[email protected]> Date: Fri Nov 3 13:37:19 2023 +0100 Start of SMT implementation for Type 2 zkEVM (#1315) * Add SMT types * Progress * Progress * Working smt hashing * Minor * Fix hash * Working insert * Minor * Add insert test for storage trie * Add missing constraints for DUP/SWAP (#1310) * Refactor wcopy syscalls * Refactor memcpy * Working test_simple_transfer * Modify add11_yml.rs * Refactor codecopy * Fix * Fix calldatacopy * Fix test on interpreter side * Remove new_stack_top_channel from StackBehavior (#1296) * Working add11_yml.rs * All tests compile * Working test_balance * Minor * Working test_extcodesize * All non-ignored tests pass * Fix test_empty_txn_list * Clippy * smt_utils point to github * Comments * Fix kexit_info in test * Review * Update Cargo.toml * Move empty check inside final iteration * Remerge context flags (#1292) * Remerge context flags * Apply comments and revert some unwanted changes * Merge NOT and POP flags. (#1257) * Merge NOT and POP flags * Add comments * Disable remaining memory channels for POP * Apply comments * Fix stack * More of memcpy_bytes * Add some documentation in EVM crate (#1295) Co-authored-by: Linda Guiga <[email protected]> * Combine PUSH0 and PC flags. (#1256) * PR feedback * Add context constraints (#1260) * Combine JUMPDEST and KECCAK_GENERAL flags. (#1259) * Combine JUMPDEST and KECCAK_GENERAL flags. * Apply comments * Fix merging of jumpdest and keccak_general. * Add test for selfdestruct (#1321) * Add test for selfdestruct * Comment * Fix test --------- Co-authored-by: Hamy Ratoanina <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Linda Guiga <[email protected]> commit ad580c2 Author: wborgeaud <[email protected]> Date: Thu Nov 2 08:40:46 2023 +0100 Clippy commit fe5b8fd Author: wborgeaud <[email protected]> Date: Thu Nov 2 08:39:26 2023 +0100 s/mpt/smt in a bunch of places commit 73dc262 Author: wborgeaud <[email protected]> Date: Thu Nov 2 08:15:56 2023 +0100 Selfdestruct test passes commit 539190f Merge: e110941 f71f227 Author: wborgeaud <[email protected]> Date: Thu Nov 2 07:58:15 2023 +0100 Merge branch 'main' into type2/smt_deletion commit e110941 Author: wborgeaud <[email protected]> Date: Wed Nov 1 17:04:38 2023 +0100 Minor commit f7fba35 Author: wborgeaud <[email protected]> Date: Wed Nov 1 12:24:13 2023 +0100 PR feedback commit e528b89 Author: wborgeaud <[email protected]> Date: Mon Oct 30 09:11:25 2023 +0100 Update Cargo.toml commit 5eaf83e Author: wborgeaud <[email protected]> Date: Fri Oct 27 12:34:52 2023 +0200 Comments commit ae9c443 Author: wborgeaud <[email protected]> Date: Fri Oct 27 11:51:16 2023 +0200 smt_utils point to github commit b3d61b7 Author: wborgeaud <[email protected]> Date: Fri Oct 27 11:49:33 2023 +0200 Clippy commit ccb3d7e Author: wborgeaud <[email protected]> Date: Fri Oct 27 10:00:20 2023 +0200 Fix test_empty_txn_list commit 986b010 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:48:14 2023 +0200 All non-ignored tests pass commit 7bb0c02 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:44:40 2023 +0200 Working test_extcodesize commit b8a85d4 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:38:08 2023 +0200 Minor commit 2c01b05 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:37:05 2023 +0200 Working test_balance commit e370b62 Author: wborgeaud <[email protected]> Date: Fri Oct 27 09:13:36 2023 +0200 All tests compile commit f21bc5c Author: wborgeaud <[email protected]> Date: Fri Oct 27 08:31:04 2023 +0200 Working add11_yml.rs commit 4e2b3f3 Author: wborgeaud <[email protected]> Date: Thu Oct 26 18:50:32 2023 +0200 Modify add11_yml.rs commit c324412 Author: wborgeaud <[email protected]> Date: Thu Oct 26 18:28:21 2023 +0200 Working test_simple_transfer commit df55e45 Author: wborgeaud <[email protected]> Date: Thu Oct 26 08:54:24 2023 +0200 Add insert test for storage trie commit ca0102f Author: wborgeaud <[email protected]> Date: Thu Oct 26 08:42:03 2023 +0200 Minor commit dc27351 Author: wborgeaud <[email protected]> Date: Thu Oct 26 08:40:57 2023 +0200 Working insert commit f6c4067 Author: wborgeaud <[email protected]> Date: Wed Oct 25 08:07:31 2023 +0200 Fix hash commit c6e85eb Author: wborgeaud <[email protected]> Date: Wed Oct 18 18:46:32 2023 +0200 Minor commit d95c430 Author: wborgeaud <[email protected]> Date: Wed Oct 18 18:32:05 2023 +0200 Working smt hashing commit fd09915 Author: wborgeaud <[email protected]> Date: Wed Oct 18 14:32:38 2023 +0200 Progress commit a706cda Author: wborgeaud <[email protected]> Date: Wed Oct 18 07:37:26 2023 +0200 Progress commit 95e5cc1 Author: wborgeaud <[email protected]> Date: Fri Oct 13 09:19:45 2023 +0200 Add SMT types * Constrain uninitialized memory to 0 (#1318) * Fix typos in comments * Fix typos in comments * Add test for ERC20 transfer (#1331) * Working test * Minor * Cleaning * Implement storage SMT * Working ERC20 test * Cleaning * Remove `len` column in `KeccakSpongeStark` (#1334) * Remove len column in KeccakSpongeStark * Apply comment Co-authored-by: Robin Salen <[email protected]> --------- Co-authored-by: Robin Salen <[email protected]> * Add withdrawals (#1322) * Withdrawals * Remove AllRecursiveCircuits in withdrawals test * Fix ERC20 test * Add memory checks for prover_input, as well as range_checks for prover_input, syscalls/exceptions (#1168) * Add memory checks for prover_input and range_checks for prover_input, syscalls and exceptions * Replace u32 by U256, and remove extra CTLs * Add column in ArithmeticStark to use ctl_arithmetic_base_rows for is_range_check * Fix CTLs and circuit constraint. * Fix CTLs * restore `no-std` support (#1335) * perform test action on `x86_64-unknown-linux-gnu` and `wasm32-unknown-unknown` Signed-off-by: muraca <[email protected]> * make `plonky2` build on `wasm32-unknown-unknown` Signed-off-by: muraca <[email protected]> * make `starky` build on `wasm32-unknown-unknown` small oversight on `plonky2` fixed Signed-off-by: muraca <[email protected]> * skip `evm` folder if target is `wasm32-unknown-unknown` Signed-off-by: muraca <[email protected]> * add `default: true` to toolchain Signed-off-by: muraca <[email protected]> * skip `test` if target is `wasm32-unknown-unknown` Signed-off-by: muraca <[email protected]> * single ticks instead of double Signed-off-by: muraca <[email protected]> * explicit target Signed-off-by: muraca <[email protected]> * wasm32 job Signed-off-by: muraca <[email protected]> * added `--no-default-features` to checks Signed-off-by: muraca <[email protected]> --------- Signed-off-by: muraca <[email protected]> * Fix create_contract_account * Fixes * More fixes * More fixes * Minor --------- Signed-off-by: muraca <[email protected]> Co-authored-by: Paul Gebheim <[email protected]> Co-authored-by: Hamy Ratoanina <[email protected]> Co-authored-by: shuoer86 <[email protected]> Co-authored-by: Robin Salen <[email protected]> Co-authored-by: Linda Guiga <[email protected]> Co-authored-by: Matteo Muraca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1215 split context flags. This PR merges them again.