Version bump pre-release #1536
Merged
Version bump pre-release #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Feb 20, 2024
| @@ -3,9 +3,9 @@ members = ["field", "maybe_rayon", "plonky2", "starky", "util"] | |||
| resolver = "2" | |||
|
|
|||
| [workspace.dependencies] | |||
| ahash = { version = "0.8.3", default-features = false, features = ["compile-time-rng"] } # NOTE: Be sure to keep this version the same as the dependency in `hashbrown`. | |||
| ahash = { version = "0.8.7", default-features = false, features = ["compile-time-rng"] } # NOTE: Be sure to keep this version the same as the dependency in `hashbrown`. | |||
There was a problem hiding this comment.
Be sure to keep this version the same as the dependency in
hashbrown.
How do you expect to do that? Like literally going to hashbrown and check which version they're using? Why?
There was a problem hiding this comment.
When we switched to hashbrown for no-std, there were some issues with conflicting ahash, so we resulted in always tracking both together. I don't think that's a big deal, we are not going to be bumping them that often anyway.
|
cpubot
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashbrown/ahashpair to get rid of possible compile issues for downstream users (stdsmidwith nightly, for ahash <= 0.8.6, see Bump ahash to fix missingstdsimdwith nightly rust-lang/hashbrown#496)cc @dlubarov @npwardberkeley, as I think you two are the owners on crates.io
closes #1520