Add STARK batching #366
Closed
Add STARK batching #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
hratoanina
commented
Jul 8, 2024
evm_arithmetization/src/prover.rs
Outdated
| { | ||
| let res = Vec::new(); | ||
|
|
||
| // TODO: Implement it. |
There was a problem hiding this comment.
Ideally we would want to use the existing compute_quotient_polys Plonky2 method, but it takes PolynomialBatch as input instead of BatchFriOracle.
| // Compute all openings: evaluate all committed polynomials at `zeta` and, when | ||
| // necessary, at `g * zeta`. | ||
| // TODO: Need batched openings. | ||
| let openings = StarkOpeningSet { |
There was a problem hiding this comment.
The StarkOpeningSet is not suited for batch openings. We would need either to create a new struct, or have e.g. a Vec<StarkOpeningSet>.
hratoanina
force-pushed
the
stark_batching
branch
from
18128d7 to
a850b26
Compare
Closed
|
Replaced by #388. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.