Prune non-necessary values from PublicValues prior 2-to-1 aggregation
#526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate: evm_arithmetization
|
We may need to expose additional/different data depending on discussions with Hermez, so putting this on hold for now. |
Nashtare
force-pushed
the
feat/prune_values
branch
from
8051706 to
4626501
Compare
|
@LindaGuiga I think the addition of the consolidated block hashes at the block layer will bring a lot of noise, so perhaps it'd be best to merge this as is and handle the addition in a follow-up PR. If this isn't reviewed by then, I'll just open the second PR against this branch. |
Nashtare
force-pushed
the
feat/prune_values
branch
from
31174c8 to
abf65dd
Compare
github-actions
bot
added
crate: mpt_trie
Nashtare
removed
crate: mpt_trie
hratoanina
reviewed
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename some methods in
proofmodule to clarify that they are declaringpublic_inputsas opposed to arbitrary targets, accordingly to the regular terminology used incircuit_buildermethods on the plonky2 side.closes #525