Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore too_long_first_doc_paragraph lint #545

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Ignore too_long_first_doc_paragraph lint #545

merged 3 commits into from
Aug 26, 2024

Conversation

LindaGuiga
Copy link
Contributor

This PR aims at making Clippy happy by ignoring the too_long_first_doc_paragraph lint

@github-actions github-actions bot added crate: proof_gen Anything related to the proof_gen crate. crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: mpt_trie Anything related to the mpt_trie crate. crate: zero_bin Anything related to the zero-bin subcrates. labels Aug 26, 2024
Nashtare
Nashtare approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I didn't expect the new linter to be polluting almost all crates. Is there a way to whitelist a lint at the workspace level directly? cc @atanmarko maybe?

@atanmarko
Copy link
Member

atanmarko commented Aug 26, 2024 •
edited
Loading

@Nashtare We take latest nightly tool-chain for lint/clippy so we pick all the latest changes and new rules. We could fix the tool-chain version (e.g. to stable).

@atanmarko
Copy link
Member

@LindaGuiga Before merging let me check if this works on the workspace level

@Nashtare
Copy link
Collaborator

@atanmarko We can't use stable, and I'd rather not pin the toolchain to a fixed version of nightly that would be get easily forgotten. Once we move into prod we can think of pinning it but for now I think we're good with the latest?

@Nashtare
Copy link
Collaborator

Nice, thanks @atanmarko!

@atanmarko
Copy link
Member

With this latest changes we add some future irritating lint rule to ignore on just one place in workspace Cargo.toml

@atanmarko atanmarko merged commit c5d542d into develop Aug 26, 2024
16 checks passed
@atanmarko atanmarko deleted the ignore-too-long-par-lint branch August 26, 2024 14:50
@Nashtare Nashtare added this to the x Misc. milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nashtare Nashtare Nashtare approved these changes

@atanmarko atanmarko atanmarko approved these changes

@0xaatif 0xaatif Awaiting requested review from 0xaatif 0xaatif is a code owner

@muursh muursh Awaiting requested review from muursh

Assignees
No one assigned
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: mpt_trie Anything related to the mpt_trie crate. crate: proof_gen Anything related to the proof_gen crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
x Misc.
Development

Successfully merging this pull request may close these issues.
3 participants
@LindaGuiga @atanmarko @Nashtare