Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce overhead in storage reads and fix stack descriptions #572

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Reduce overhead in storage reads and fix stack descriptions #572

merged 2 commits into from
Sep 2, 2024

Conversation

Nashtare
Copy link
Collaborator

I initially just wanted to reduce the overhead around storage_key_exists as we now don't store storage value pointers but the values directly, but then I realized a bunch of stack descriptions in linked_list.asm were outdated, following #433

@Nashtare Nashtare self-assigned this Aug 31, 2024
@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Aug 31, 2024
@Nashtare Nashtare added this to the Performance Tuning milestone Sep 1, 2024
@Nashtare Nashtare merged commit b938b63 into develop Sep 2, 2024
15 checks passed
@Nashtare Nashtare deleted the misc/overhead_sload branch September 2, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muursh muursh muursh approved these changes

@LindaGuiga LindaGuiga Awaiting requested review from LindaGuiga LindaGuiga is a code owner

Assignees

@Nashtare Nashtare

Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Zero EVM
Status: Done
Milestone
Performance Tuning
Development

Successfully merging this pull request may close these issues.
2 participants
@Nashtare @muursh