Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary overhead in linked list preprocessing #642

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Nashtare
Copy link
Collaborator

The steps insert_all_slots_in_memory and insert_all_accounts_in_memory actually don't do anything, because we're inserting exactly the accounts and slots we've already added when processing the trie data.

cc @4l0n50

@Nashtare Nashtare added this to the Performance Tuning milestone Sep 18, 2024
@Nashtare Nashtare requested a review from 4l0n50 September 18, 2024 22:33
@Nashtare Nashtare self-assigned this Sep 18, 2024
@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Sep 18, 2024
@4l0n50
Copy link
Contributor

4l0n50 commented Sep 19, 2024

You're right. I forgot to remove this part on my previous PR. Thanks!

Copy link
Contributor

@4l0n50 4l0n50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@LindaGuiga LindaGuiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nashtare Nashtare merged commit 3af1f29 into develop Sep 19, 2024
17 checks passed
@Nashtare Nashtare deleted the misc/remove_unneeded_processing branch September 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants