-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefetch JUMPDESTs through RPC with progressive proving #765
Draft
einar-polygon
wants to merge
113
commits into
develop
Choose a base branch
from
einar/prefetch_transaction_jumps/mem-opt
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports CREATE1/CREATE2 Supports transaction deployments Includes test scripts for randomised testing
…nsaction_jumps/pr
…nsaction_jumps/pr
This reverts commit a6ba0e5.
einar-polygon
added
crate: evm_arithmetization
Anything related to the evm_arithmetization crate.
crate: zero_bin
Anything related to the zero-bin subcrates.
labels
Nov 3, 2024
github-actions
bot
added
crate: trace_decoder
Anything related to the trace_decoder crate.
ci
labels
Nov 3, 2024
QQ: shouldn't this be targeting the JD branch instead of develop? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
crate: evm_arithmetization
Anything related to the evm_arithmetization crate.
crate: trace_decoder
Anything related to the trace_decoder crate.
crate: zero_bin
Anything related to the zero-bin subcrates.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work in #427 and addresses one problem:
CREATE
andCREATE2
required memory dumps to obtain the relevant contractcode
andcode_hash
for call stack simulation, and we opted instead to fail over to simulation, since memory dumps were slow.This branch introduces the following changes:
CREATE
andCREATE2
, but ignorecode
andcode_hash
.code_hash
andcontext
. This change means two things:current_code
andcurrent_code_hash
is always available, so we do away with the mapping in the witness, essentially simplifying it to a mappingctx->[offset]
.code
andcode_hash
in the Jumpdest generation.Status: The first 100 blocks on testchain2 succeed, but there are still many errors later.