Add a Safe Guard that implements a timelock for the upgrade Safe #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 307bb0a.
duncancmt
force-pushed
the
dcmt/upgrade-timelock
branch
from
36e9419 to
0751f8c
Compare
…stead of mapping from the hash to the expiry
…ta` and `getTransactionHash`
…is improves the UX of using the guard It still requires 2 transactions to be submitted. There's no way around that.
…, but we want to wear tinfoil
…`unlock` transaction hash; this prevents a rogue owner from repeatedly calling `cancel` to brick the safe
duncancmt
changed the title
duncancmt
force-pushed
the
dcmt/upgrade-timelock
branch
from
162354a to
56dab72
Compare
duncancmt
force-pushed
the
dcmt/upgrade-timelock
branch
from
8bb0aa5 to
56dab72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.