Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update starknet-rs to fix offset serde #239

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Update starknet-rs to fix offset serde #239

merged 3 commits into from
Nov 6, 2023

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Nov 2, 2023

Usage related changes

Development related changes

  • Updates starknet-rs crates to latest versions
    • In test_simulate_transactions.rs this required introducing a new necessary boolean argument to some functions.

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

@FabijanC FabijanC changed the title Fix offset serde Update starknet-rs to fix offset serde Nov 6, 2023
@FabijanC FabijanC merged commit c8af0bb into main Nov 6, 2023
@FabijanC FabijanC deleted the fix-offset-serde branch November 6, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on sending declare v1 transaction (declaring cairo 0 contract)
2 participants
@FabijanC @marioiordanov