0.6 spec #273

marioiordanov · 2023-12-06T10:32:40Z

Usage related changes

0.6.0 RPC spec

Development related changes

added not property to spec reader
refactored BroadcastedInvokeTransaction, BroadcastedDeployAccountTransaction to be enum with variants
updated starknet-rs
added method into_vec for converting vector of elements to vector of another elements, when From trait is implemented
added test utility methods for V3 transactions
added V3 transactions and unit tests for them
use spec 0.6.0-rc5
added contract address(https://testnet.starkscan.co/contract/0x04718f5a0fc34cc1af16a1cdee98ffb20c31f5cd61d6ab07201858f4287c938d) for starknet token similar to ETH. Predeployed accounts initial balance is changed for ETH and STRK
renamed ERC20_CONTRACT_ADDRESS to ETH_ERC20_CONTRACT_ADDRESS
refactored Accounted trait -> get_balance to return the balance in the ETH or STRK
made chargeable account owner of ETH and STRK contracts
added custom serialization for ResourceBoundsMapping, because according to the spec l1_gas and l2_gas are lowercase keys, but in the ResourceBoundsMapping map the keys are uppercase
added simulation_flags input parameter to estimate_fee
marked multiple integration tests with [ignore] attribute, because current starknet-rs version doesnt support simulation_flags for estimate_fee - Many ignored methods #274
edited message on devnet startup, to show that the initial balance is in WEI and STRK
updated README.md
created an issue about integration tests V3 transactions integration tests #275
changed resource price field name from price_in_strk to price_in_fri
changed execution resources type from Felt to usize
refactored common transaction receipt by removing transaction output
receipt returns actual fee as object
set default value to price_in_fri

Checklist:

renamed and refactored create_erc20 to create_erc20_at_address renamed and refactored initialize_erc20 to intialize_erc20_at_address

… accept FeeToken enum as parameter

…dress. get_balance method accepts an enum to return corresponding balance. adapted tests

… letters, but starknet_api use serde_rename with uppercase

marioiordanov · 2023-12-07T15:45:14Z

Hi @marioiordanov, can you please add FEE_PAYMENT along with its usages?
@marioiordanov There are few more issues I came across so far:

Missing execution_resources in FUNCTION_INVOCATION

price_in_fri of l1_gas_price is not always returned e.g. when making a starknet_getBlockWithTxs or starknet_getBlockWithTxHashes request

@DelevoXDG the commits after your comments address the requested changes

DelevoXDG · 2023-12-07T15:47:20Z

Thanks!

marioiordanov · 2023-12-07T15:48:16Z

Thanks!

the next commit will address the execution_resources in FUNCTION_INVOCATION

…et-rs version doesnt support simulation flags. Ignored one method due to starknet-rs not supporting actual fee as an object in the transaction receipt

FabijanC

Can the two old comments with this content:

// TODO: in spec RPC response the contract class is missing

be resolved now?

For hash calculation logic, I stopped carefully reviewing it after I realized it's all tested against real transactions and is producing expected hash values.

crates/starknet-server/tests/test_account_selection.rs

crates/types/src/rpc/transactions.rs

crates/types/src/rpc/transactions/broadcasted_invoke_transaction_v3.rs

crates/starknet-server/src/main.rs

crates/starknet/src/starknet/mod.rs

crates/starknet/src/starknet/estimations.rs

crates/starknet/src/transactions.rs

crates/types/src/rpc/transaction_receipt.rs

crates/starknet/src/starknet/add_invoke_transaction.rs

crates/types/src/rpc/transactions/broadcasted_deploy_account_transaction_v3.rs

… only for test mode

marioiordanov · 2023-12-11T14:21:15Z

Can the two old comments with this content:
// TODO: in spec RPC response the contract class is missing
be resolved now?

For hash calculation logic, I stopped carefully reviewing it after I realized it's all tested against real transactions and is producing expected hash values.

No, because this is the reason for this issue #248 . Dump functionality needs refactor

marioiordanov added 30 commits November 24, 2023 18:13

added spec

2d1d33f

0.6.0 spec modified

eb6f4a8

added not property only for deserialization purpose

004cd25

remove trailing comma

1e28e26

refactor broadcastedinvoketransaction

e8568c9

new chain id

72f055d

updated starknet-rs

4db28f1

utility method for converting vector to vector

b240179

test util method to convert int to data availability mode

bc40dcd

comments

028cac5

make prefix public in crate

ca07ca3

invoke v3 and declare v3

3b9a5b1

refactor deploy account v1

197b5c6

added deploy account v3 transaction

043a8c5

clippy

61f3480

added convertion to blockifier deploy account

3ae6bc8

Merge branch 'main' into 0.6-spec

c830f3a

update starknet-rs dependency

1ecf472

changed spec name from 0.6.0 to 0.6.0-rc1

4eac20f

added new constant for starknet fee token address

efa00f1

added starknet fee token address to init_block_context

5267182

renamed ERC20_CONTRACT_ADDRESS to ETH_ERC20_CONTRACT_ADDRESS

fe763c4

renamed and refactored create_erc20 to create_erc20_at_address renamed and refactored initialize_erc20 to intialize_erc20_at_address

update Accounted trait comments and get_balance method signature to…

35ebcc7

… accept FeeToken enum as parameter

predeployed accounts accept strk as address for fees

f351b4a

refactored chargeable account and account to accept strk_fee_token_ad…

43476df

…dress. get_balance method accepts an enum to return corresponding balance. adapted tests

invoke v3 transaction execution

ea3c814

declare v3 and deploy account v3

a3603ae

clippy

ac5e15e

added to endpoints [skip ci]

f0d491c

deserialization helper because resource bounds keys come as lowercase…

41454bc

… letters, but starknet_api use serde_rename with uppercase

marioiordanov mentioned this pull request Dec 7, 2023

JSON-RPC methods returning extra properties not in the spec #248

Closed

marioiordanov added 7 commits December 8, 2023 15:59

added execution resources and removed FunctionCall

dab026e

fix data generator for objects when it is close to the max depth

722e1d6

Merge branch 'main' into 0.6-spec

9485dd2

fixes after merge

71c9b20

execution resources serialization fix

bf07e6e

specify max_fee so methods avoid calling estimate fee, because starkn…

110c09d

…et-rs version doesnt support simulation flags. Ignored one method due to starknet-rs not supporting actual fee as an object in the transaction receipt

clippy

fa61ab1

FabijanC requested changes Dec 11, 2023

View reviewed changes

marioiordanov added 12 commits December 11, 2023 12:40

removed println

6ecca06

added println [skip ci]

d217854

remove irrelevant comment about fee check [skip ci]

e0186d9

removed test [skip ci]

7817038

refactored partially FeeEstimateWrapper [skip ci]

658a994

reordered arguments in init_block_context method

27bdb45

removed warning [skip ci]

2d24108

renamed STRK in FeeInUnits to FRI [skip ci]

f2d0209

remove Eq, PartialEq derivations

d25f51d

removed some Serialize derivations, make some Deserialize derivations…

2e7f145

… only for test mode

removed SyncStatus due to clippy complain, edited spec instructions

57d3a0d

return untagged attribute

caa98c1

improved logic for units of fee for transaction types [skip ci]

9204620

FabijanC approved these changes Dec 11, 2023

View reviewed changes

marioiordanov merged commit 85495ef into main Dec 11, 2023

marioiordanov deleted the 0.6-spec branch December 11, 2023 15:53

FabijanC mentioned this pull request Dec 14, 2023

Missing panic reason when transaction fails during account validation #286

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

0.6 spec #273

0.6 spec #273

marioiordanov commented Dec 6, 2023 •

edited

Loading

marioiordanov commented Dec 7, 2023

DelevoXDG commented Dec 7, 2023

marioiordanov commented Dec 7, 2023

FabijanC left a comment

marioiordanov commented Dec 11, 2023

0.6 spec #273

0.6 spec #273

Conversation

marioiordanov commented Dec 6, 2023 • edited Loading

Usage related changes

Development related changes

Checklist:

marioiordanov commented Dec 7, 2023

DelevoXDG commented Dec 7, 2023

marioiordanov commented Dec 7, 2023

FabijanC left a comment

Choose a reason for hiding this comment

marioiordanov commented Dec 11, 2023

marioiordanov commented Dec 6, 2023 •

edited

Loading