Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reorg subscription #653

Merged
merged 16 commits into from
Nov 28, 2024
Merged

Support reorg subscription #653

merged 16 commits into from
Nov 28, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Nov 27, 2024

Usage related changes

Development related changes

  • Only check for changes if request requires so (introduce new method for this: requires_notifying).
    • The new method relies on clippy warning to be issued if wildcard matching used, to force explicitly defining behavior for each request: wildcard_enum_match_arm.
  • Refactor Subscription::matches method to avoid using if.
  • Make abort_blocks a method of BackgroundDevnet and use it where possible instead of sending custom requests.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC marked this pull request as ready for review November 28, 2024 09:31
@FabijanC FabijanC merged commit 6a07b69 into json-rpc-v0.8.0 Nov 28, 2024
@FabijanC FabijanC deleted the reorg-subscription branch November 28, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants