Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature tags + pow #3

Merged
merged 2 commits into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,6 @@ criterion = { version = "0.5.1", features = ["html_reports"] }
[[bench]]
name = "benchmark"
harness = false

[features]
parallel = []
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ Generate benchmarks using:

```bash
# If you don't have it already
cargo install cargo-criterion criterion-table
cargo install cargo-criterion criterion-table --cfg

cargo criterion --message-format=json | criterion-table > BENCHMARKS.md
cargo criterion --message-format=json --features parallel | criterion-table > BENCHMARKS.md
```

Benchmarks are also available [here](./BENCHMARKS.md)
64 changes: 64 additions & 0 deletions src/ntt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ fn order_reverse(inp: &mut Vec<BigInt>) {
});
}

#[cfg(feature = "parallel")]
fn fft(inp: Vec<BigInt>, c: &Constants, w: BigInt) -> Vec<BigInt> {
assert!(inp.len().is_power_of_two());
let mut inp = inp.clone();
Expand Down Expand Up @@ -123,10 +124,62 @@ fn fft(inp: Vec<BigInt>, c: &Constants, w: BigInt) -> Vec<BigInt> {
inp
}

#[cfg(not(feature = "parallel"))]
fn fft(inp: Vec<BigInt>, c: &Constants, w: BigInt) -> Vec<BigInt> {
assert!(inp.len().is_power_of_two());
let mut inp = inp.clone();
let N = inp.len();
let MOD = BigInt::from(c.N);
let ONE = BigInt::from(1);
let mut pre: Vec<BigInt> = vec![ONE; N / 2];
let CHUNK_COUNT = 128;
let chunk_count = BigInt::from(CHUNK_COUNT);

pre.chunks_mut(CHUNK_COUNT)
.enumerate()
.for_each(|(i, arr)| arr[0] = w.mod_exp(BigInt::from(i) * chunk_count, MOD));
pre.chunks_mut(CHUNK_COUNT).for_each(|x| {
(1..x.len()).for_each(|y| {
let _x = x.to_vec();
x[y] = (w * x[y - 1]).rem(MOD);
})
});
order_reverse(&mut inp);

let mut gap = 1;

while gap < inp.len() {
let nchunks = inp.len() / (2 * gap);
inp.chunks_mut(2 * gap).for_each(|cxi| {
let (lo, hi) = cxi.split_at_mut(gap);
lo.iter_mut()
.zip(hi)
.enumerate()
.for_each(|(idx, (lo, hi))| {
*hi = (*hi * pre[nchunks * idx]).rem(MOD);
let neg = if *lo < *hi {
(MOD + *lo) - *hi
} else {
*lo - *hi
};
*lo = if *lo + *hi >= MOD {
(*lo + *hi) - MOD
} else {
*lo + *hi
};
*hi = neg;
});
});
gap *= 2;
}
inp
}

pub fn forward(inp: Vec<BigInt>, c: &Constants) -> Vec<BigInt> {
fft(inp, c, c.w)
}

#[cfg(feature = "parallel")]
pub fn inverse(inp: Vec<BigInt>, c: &Constants) -> Vec<BigInt> {
let mut inv = BigInt::from(inp.len());
let _ = inv.set_mod(c.N);
Expand All @@ -137,6 +190,17 @@ pub fn inverse(inp: Vec<BigInt>, c: &Constants) -> Vec<BigInt> {
res
}

#[cfg(not(feature = "parallel"))]
pub fn inverse(inp: Vec<BigInt>, c: &Constants) -> Vec<BigInt> {
let mut inv = BigInt::from(inp.len());
let _ = inv.set_mod(c.N);
let inv = inv.invert();
let w = c.w.invert();
let mut res = fft(inp, c, w);
res.iter_mut().for_each(|x| *x = (inv * (*x)).rem(c.N));
res
}

#[cfg(test)]
mod tests {
use rand::Rng;
Expand Down
6 changes: 6 additions & 0 deletions src/numbers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ impl BigInt {
*self.v.params()
}

pub fn pow(&self, n: u128) -> BigInt {
BigInt {
v: self.v.pow(&Uint::<4>::from_u128(n)),
}
}

pub fn mod_exp(&self, exp: BigInt, M: BigInt) -> BigInt {
let mut res: BigInt = if !exp.is_even() {
self.clone()
Expand Down
33 changes: 33 additions & 0 deletions src/polynomial.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ impl Polynomial {
Polynomial { coef: out }
}

#[cfg(feature = "parallel")]
pub fn mul(self, rhs: Polynomial, c: &Constants) -> Polynomial {
let v1_deg = self.degree();
let v2_deg = rhs.degree();
Expand Down Expand Up @@ -81,6 +82,38 @@ impl Polynomial {
}
}

#[cfg(not(feature = "parallel"))]
pub fn mul(self, rhs: Polynomial, c: &Constants) -> Polynomial {
let v1_deg = self.degree();
let v2_deg = rhs.degree();
let n = (self.len() + rhs.len()).next_power_of_two();
let ZERO = BigInt::from(0);

let v1 = vec![ZERO; n - self.len()]
.into_iter()
.chain(self.coef.into_iter())
.collect();
let v2 = vec![ZERO; n - rhs.len()]
.into_iter()
.chain(rhs.coef.into_iter())
.collect();

let a_forward = forward(v1, &c);
let b_forward = forward(v2, &c);

let mut mul = vec![ZERO; n as usize];
mul.iter_mut()
.enumerate()
.for_each(|(i, x)| *x = (a_forward[i] * b_forward[i]).rem(c.N));

let coef = inverse(mul, &c);
// n - polynomial degree - 1
let start = n - (v1_deg + v2_deg + 1) - 1;
Polynomial {
coef: coef[start..=(start + v1_deg + v2_deg)].to_vec(),
}
}

pub fn diff(mut self) -> Self {
let N = self.len();
for n in (1..N).rev() {
Expand Down