-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes error: Correctly sets YouTube consent cookie #524
base: master
Are you sure you want to change the base?
Conversation
@ekincelik Still it is not working with some urls and giving me error with reason string "Video unavailable". Please check it. Domain: XCDYouTubeVideoErrorDomain Below Url is not working |
Works for me with my pull request |
Works, thanks! |
I had downloaded the code from alexeichhorn:fix/youtube-consent branch and added the required XCDYoutubeKit folder into project, because there is no new pod version available for this fix. I run the project on real device and observed that https://www.youtube.com/watch?v=J6R4u8jSkh4 url gives me same error video unavailable. Am I doing anything wrong here, how it’s working for u and not for me. Please suggest we depends on this lib and in a release phase. Please advise. |
I tested your video using the demo application in the repository, which worked, and used SwiftPM to integrate the framework in my application where I haven't tested your video, but a lot of others. |
hi @Praveen-Balpande |
Hi everyone, I am getting this error while playing video id "E_lByLdKeKY" 2021-05-13 16:39:53.974689+0530 Quizzwizz[1362:383440] [XCDYouTubeKit] Failed to decode response from https://www.youtube.com/get_video_info?el=embedded&hl=en&ps=default&video_id=E_lByLdKeKY (response.textEncodingName = utf-8, data.length = 0) please note the video works on simulator but giving error on device. please help as we are about to release our app tomorrow. |
It works for me, thanks a lot |
please help me also...in my app most of the videos are not getting played..:( |
Hi to the file: Hope that helps |
Can you add the fix from other pull-requests: |
@sherwinzadeh I've merged both pull requests in the master branch of my fork. I use it myself in SwiftPM for my own project. |
Hi, can you please write what is the correct pod file entry for your fork? |
Hey,
Great work with your repo. I've seen that YouTube made some changes recently that make XCDYouTubeKit fail in many regions. The issue was "discussed" in #523.
I implemented the same solution as in youtube-dl commit 14f29f. It basically has to set a "consent-cookie" so YouTube sees you agree with their terms and conditions, cookie rules or whatever.
Would be happy to hear your feedback