refactor: remove usage of unstable generic_const_exprs
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starky/src/evaluation_frame.rs
Outdated
| const PUBLIC_INPUTS: usize; | ||
|
|
||
| /// Returns the local values (i.e. current row) for this evaluation frame. | ||
| fn get_local_values(&self) -> &[P]; |
There was a problem hiding this comment.
Suggested change
| fn get_local_values(&self) -> &[P]; | |
| fn local_values(&self) -> &[P]; |
But I'm not sure if that shorter name won't lead to clashes?
(If not, perhaps we can remove the other get_-prefixes as well.)
eightfilms
changed the title
| @@ -1,7 +1,6 @@ | |||
| #![allow(incomplete_features)] | |||
| #![allow(clippy::too_many_arguments)] | |||
| #![allow(clippy::type_complexity)] | |||
| #![feature(generic_const_exprs)] | |||
matthiasgoergens
approved these changes
Oct 9, 2023
eightfilms
changed the title
eightfilms
changed the title
generic_const_exprs
eightfilms
added a commit
that referenced
this pull request
Oct 21, 2023
refactor: remove usage of unstable `generic_const_exprs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all usage of
generic_const_exprswithin thestarkycrate. The feature has been mostly a pain to deal with, leading to hours of trying to debugunconstrained generic consterrors. This removes the feature entirely, much thanks to following the convention upstream.