Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FLUT-253: Moved all permissions from app to sdk #1787

Merged
merged 5 commits into from
Jun 12, 2024
Merged

FLUT-253: Moved all permissions from app to sdk #1787

merged 5 commits into from
Jun 12, 2024

Conversation

Decoder07
Copy link
Contributor

Description

  • Removed permissions from application

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@Decoder07 Decoder07 requested a review from ygit June 12, 2024 11:11
@Decoder07 Decoder07 marked this pull request as draft June 12, 2024 11:12
@Decoder07 Decoder07 marked this pull request as ready for review June 12, 2024 12:15
ygit
ygit approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygit ygit merged commit 96615c6 into develop Jun 12, 2024
3 checks passed
@ygit ygit deleted the FLUT-253 branch June 12, 2024 13:50
Decoder07 added a commit that referenced this pull request Jul 29, 2024
@Decoder07
FLUT-253: Moved all permissions from app to sdk (#1787)
15997f1 
* Moved all permissions from app to sdk

* Moved all permissions from app to sdk

* testing permissions

* testing permissions

* Updated Permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygit ygit ygit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Decoder07 @ygit