Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Leave room renders blank screen #1805

Merged
merged 4 commits into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/hms_room_kit/lib/src/meeting/meeting_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ class _MeetingPageState extends State<MeetingPage> {
builder: (_, failureErrors, __) {
if (failureErrors.item1) {
WidgetsBinding.instance.addPostFrameCallback((_) {
context.read<MeetingStore>().removeAllBottomSheets();
Navigator.of(context).pushReplacement(MaterialPageRoute(
builder: (context) => HMSLeftRoomScreen(
isEndRoomCalled: failureErrors.item3,
Expand Down
1 change: 0 additions & 1 deletion packages/hms_room_kit/lib/src/meeting/meeting_store.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1433,7 +1433,6 @@ class MeetingStore extends ChangeNotifier

void clearRoomState() async {
// clearPIPState();
removeAllBottomSheets();
removeListeners();
toggleAlwaysScreenOn();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ class _EndServiceBottomSheetState extends State<EndServiceBottomSheet> {
if (widget.onButtonPressed != null) {
widget.onButtonPressed!();
}
context.read<MeetingStore>().removeBottomSheet(context);
Navigator.pop(context);
},
child: SizedBox(
Expand Down
4 changes: 2 additions & 2 deletions packages/hmssdk_flutter/example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ android {
applicationId "live.hms.flutter"
minSdkVersion 21
targetSdkVersion 34
versionCode 516
versionName "1.5.216"
versionCode 517
versionName "1.5.217"
}

signingConfigs {
Expand Down
4 changes: 2 additions & 2 deletions packages/hmssdk_flutter/example/ios/Runner/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.5.216</string>
<string>1.5.217</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand All @@ -48,7 +48,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>516</string>
<string>517</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationCategoryType</key>
Expand Down