Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft PR]: Music mode #1809

Closed
wants to merge 106 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
3ef492b
added property for gain and noise supression
Decoder07 May 1, 2024
9a8860d
FLUT-284: Added `onPeerListUpdate` callback in preview (#1762)
Decoder07 May 7, 2024
c0f5d36
FLUT-298: Whiteboard Support in flutter SDK and prebuilt (#1761)
Decoder07 May 10, 2024
af046fa
Fixed audio track settings (#1765)
Decoder07 May 10, 2024
dc57324
Added HLS Stats (#1766)
Decoder07 May 10, 2024
06ff6d4
FLUT-251: Added one to one callkit app (#1745)
Decoder07 May 13, 2024
f7d2ee9
Added whiteboard sdk changes (#1767)
Decoder07 May 15, 2024
31f8933
Added missing line
Decoder07 May 15, 2024
70bfc48
Added EOFL
Decoder07 May 15, 2024
19f2275
Updated docs link
Decoder07 May 15, 2024
64231ba
Updated hmssdk_flutter to 1.10.2
Decoder07 May 15, 2024
53ccea1
🤖 Automated Format and Fix
Decoder07 May 15, 2024
4e227e4
Fixed lint errors
Decoder07 May 15, 2024
c74a25c
bumped package versions
ygit May 15, 2024
945a59b
FLUT-275: Hand raise will honour layout config (#1771)
Decoder07 May 24, 2024
b20a96a
Added empty room screens
Decoder07 May 27, 2024
a18fc79
🤖 Automated Format and Fix
Decoder07 May 27, 2024
af3e355
updated sdk versions (#1773)
Decoder07 May 27, 2024
2b04f29
added blur option in iOS
Decoder07 May 20, 2024
4e20fcf
Merged main
Decoder07 Jul 29, 2024
609dc8c
released sample app version 1.5.194 (494) 🍀
Decoder07 May 22, 2024
89d80e5
🤖 Automated Format and Fix
Decoder07 May 22, 2024
94ff5e5
Updated method return type
Decoder07 May 23, 2024
f868aa2
Resolved conflicts
Decoder07 May 23, 2024
be0fb31
Fixed error
Decoder07 May 23, 2024
51c70db
Added result in iOS method
Decoder07 May 23, 2024
2fb2bea
added vb instance instead of singleton
ygit May 23, 2024
aef36fc
corrected typo
ygit May 23, 2024
6eb7e56
corrected typo
ygit May 23, 2024
18c79e3
updated pods
ygit May 23, 2024
7975173
corrected typo
ygit May 23, 2024
58ba8bf
Merged changes
Decoder07 May 23, 2024
4fa443e
released sample app version 1.5.195 (495) 🍀
Decoder07 May 23, 2024
53568d4
Removed hms_video_plugin package from repo
Decoder07 May 27, 2024
4cdc1c3
Removed unused code
Decoder07 May 27, 2024
d1eddc7
Removed unused import
Decoder07 May 27, 2024
49c2c0f
Removed unused code
Decoder07 May 27, 2024
9949227
Updated proguard
Decoder07 May 28, 2024
f68fb61
Updated changelog
Decoder07 May 28, 2024
a8dd45c
released sample app version 1.5.196 (496) 🍀
Decoder07 May 28, 2024
d8e5ad1
Foreground task fix (#1777)
Decoder07 May 30, 2024
60f9dc2
updated sdk version
Decoder07 Jun 3, 2024
cb20233
🤖 Automated Format and Fix
Decoder07 Jun 3, 2024
ce0a637
Updated sdk version in changelog
Decoder07 Jun 4, 2024
d8dc592
released sample app version 1.5.197 (497) 🍀
Decoder07 Jun 5, 2024
7944c77
Updated vb functionality
Decoder07 Jun 6, 2024
4892401
Bloc app update (#1779)
Decoder07 Jun 3, 2024
35cce50
Added addTrack call explicitly (#1780)
Decoder07 Jun 6, 2024
f614a93
🤖 Automated Format and Fix
Decoder07 Jun 6, 2024
164eabc
released sample app version 1.5.198 (498) 🍀
Decoder07 Jun 6, 2024
5ab634f
removed Mac support from the iOS app (#1782)
ygit Jun 6, 2024
aef0d0f
FLUT-326: Removed pop up in full screen share (#1783)
Decoder07 Jun 7, 2024
f8d32ac
Updated iOS sdk (#1784)
Decoder07 Jun 7, 2024
ab4ab28
released sample app version 1.5.199 (499) 🍀
Decoder07 Jun 7, 2024
6dac3b2
Hide virtual background option for vrt user (#1785)
Decoder07 Jun 7, 2024
3df63b3
released sample app version 1.5.200 (500) 🍀
Decoder07 Jun 7, 2024
1ec78ba
released sample app version 1.5.201 (501) 🍀
Decoder07 Jun 10, 2024
f72cdab
removed vb changes
Decoder07 Jun 10, 2024
ae89f37
🤖 Automated Format and Fix
Decoder07 Jun 10, 2024
6632616
Updated changelog
Decoder07 Jun 10, 2024
1ecf005
Removed VB key
Decoder07 Jun 10, 2024
9c434b8
Added method comments
Decoder07 Jun 10, 2024
f31d272
🤖 Automated Format and Fix
Decoder07 Jun 10, 2024
8c39acc
Updated changelog
Decoder07 Jun 11, 2024
3461c45
released sample app version 1.5.202 (502) 🍀
Decoder07 Jun 11, 2024
07c17b9
removed unused import
Decoder07 Jun 11, 2024
e925c99
Updated hmssdk version to 1.10.3 in hms_room_kit
Decoder07 Jun 12, 2024
9f5de67
🤖 Automated Format and Fix
Decoder07 Jun 12, 2024
15997f1
FLUT-253: Moved all permissions from app to sdk (#1787)
Decoder07 Jun 12, 2024
020d3a2
released sample app version 1.5.203 (503) 🍀
Decoder07 Jun 12, 2024
bab5499
Updated SDK version (#1788)
Decoder07 Jun 12, 2024
240cba7
Updated room kit to v2 embedding (#1789)
Decoder07 Jun 13, 2024
5b464ed
Iss 22680 (#1790)
Decoder07 Jun 28, 2024
d1ddb0d
Added release notes for 1.10.4 (#1791)
Decoder07 Jun 28, 2024
5021b90
Addd transcription view
Decoder07 Jul 1, 2024
3b2f9bb
Added library annotation
Decoder07 Jul 1, 2024
e731085
Updated date
Decoder07 Jul 1, 2024
83470d3
Updated spacing package versions
Decoder07 Jul 1, 2024
2bea96b
Updated hmssdk_flutter version to 1.10.4
Decoder07 Jul 1, 2024
e4a0b89
🤖 Automated Format and Fix
Decoder07 Jul 1, 2024
3a23369
Updated sdk to 1.10.5 (#1794)
Decoder07 Jul 1, 2024
85d825a
ISS-22834: Transcription parity across platforms (#1793)
Decoder07 Jul 2, 2024
55905b5
Added noise cancellation controls from prebuilt (#1795)
Decoder07 Jul 2, 2024
7022bca
Updated changelog
Decoder07 Jul 2, 2024
4a60fd5
released sample app version 1.5.210 (510) 🍀
Decoder07 Jul 2, 2024
3cc6bba
Foreground microphone fix (#1797)
Decoder07 Jul 8, 2024
489334b
Fixed noise cancellation property on android from dashboard (#1798)
Decoder07 Jul 23, 2024
5f4b749
Updated SDK version and added change log (#1802)
Decoder07 Jul 23, 2024
c281667
released sample app version 1.5.215 (515) 🍀
Decoder07 Jul 23, 2024
d09796c
Updated iOS SDK version
Decoder07 Jul 23, 2024
b366170
updated ReadMe
ygit Jul 24, 2024
710077d
updated ReadMe
ygit Jul 24, 2024
efbf6af
updated ReadMe
ygit Jul 24, 2024
637dc6a
updated image path
ygit Jul 24, 2024
a330709
updated image paths
ygit Jul 24, 2024
fba8133
fix: Added fix for end room with bottom sheet (#1803)
Decoder07 Jul 24, 2024
501ba7e
released sample app version 1.5.216 (516) 🍀
Decoder07 Jul 24, 2024
dce87ab
Fix: Leave room renders blank screen (#1805)
Decoder07 Jul 25, 2024
430207b
released sample app version 1.5.218 (518) 🍀
Decoder07 Jul 25, 2024
54f3833
updated readme
Decoder07 Jul 25, 2024
1d49b52
Updated hmssdk_flutter version to 1.10.5
Decoder07 Jul 25, 2024
31bc42e
🤖 Automated Format and Fix
Decoder07 Jul 25, 2024
f1710f4
Merged main
Decoder07 Jul 29, 2024
dcf23ca
Merged main
Decoder07 Jul 29, 2024
2c99781
Added userName in prebuilt options
Decoder07 Jul 31, 2024
6a70004
🤖 Automated Format and Fix
Decoder07 Aug 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/hms_room_kit/example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,9 @@ packages:
hmssdk_flutter:
dependency: transitive
description:
name: hmssdk_flutter
sha256: "2da8500708d8a8ebfa3d3ffb2f1deafd0ff23828dfaff6fdd1b4367da6337cf0"
url: "https://pub.dev"
source: hosted
path: "../../hmssdk_flutter"
relative: true
source: path
version: "1.10.5"
http:
dependency: transitive
Expand Down
6 changes: 5 additions & 1 deletion packages/hms_room_kit/lib/src/common/utility_functions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,8 @@ class Utilities {
required bool joinWithMutedAudio,
required bool isSoftwareDecoderDisabled,
required bool isNoiseCancellationEnabled,
required bool isAutomaticGainControlEnabled,
required bool isNoiseSuppressionEnabled,
HMSAudioMode? audioMode,
}) {
return HMSTrackSetting(
Expand All @@ -414,7 +416,9 @@ class Utilities {
? HMSTrackInitState.MUTED
: HMSTrackInitState.UNMUTED,
audioMode: audioMode,
enableNoiseCancellation: isNoiseCancellationEnabled),
enableNoiseCancellation: isNoiseCancellationEnabled,
enableAutomaticGainControl: isAutomaticGainControlEnabled,
enableNoiseSupression: isNoiseSuppressionEnabled),
videoTrackSetting: HMSVideoTrackSetting(
trackInitialState: joinWithMutedVideo
? HMSTrackInitState.MUTED
Expand Down
4 changes: 3 additions & 1 deletion packages/hms_room_kit/lib/src/hmssdk_interactor.dart
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ class HMSSDKInteractor {
joinWithMutedAudio: joinWithMutedAudio,
isSoftwareDecoderDisabled: isSoftwareDecoderDisabled,
audioMode: audioMode,
isNoiseCancellationEnabled: isNoiseCancellationEnabled);
isNoiseCancellationEnabled: isNoiseCancellationEnabled,
isAutomaticGainControlEnabled: true,
isNoiseSuppressionEnabled: true);

hmsSDK = HMSSDK(
iOSScreenshareConfig: iOSScreenshareConfig,
Expand Down
4 changes: 3 additions & 1 deletion packages/hms_room_kit/lib/src/preview_meeting_flow.dart
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ class _PreviewMeetingFlowState extends State<PreviewMeetingFlow> {
Widget build(BuildContext context) {
return HMSRoomLayout.skipPreview
? MeetingScreenController(
user: widget.prebuiltOptions?.userId ?? "",
user: widget.prebuiltOptions?.userName ??
widget.prebuiltOptions?.userId ??
"",
localPeerNetworkQuality: null,
options: widget.prebuiltOptions,
tokenData: widget.tokenData,
Expand Down
7 changes: 3 additions & 4 deletions packages/hms_room_kit/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,9 @@ packages:
hmssdk_flutter:
dependency: "direct main"
description:
name: hmssdk_flutter
sha256: "2da8500708d8a8ebfa3d3ffb2f1deafd0ff23828dfaff6fdd1b4367da6337cf0"
url: "https://pub.dev"
source: hosted
path: "../hmssdk_flutter"
relative: true
source: path
version: "1.10.5"
http:
dependency: transitive
Expand Down
3 changes: 2 additions & 1 deletion packages/hms_room_kit/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ dependencies:
flutter:
sdk: flutter

hmssdk_flutter: 1.10.5
hmssdk_flutter:
path: ../hmssdk_flutter
intl: ^0.19.0
permission_handler: ^11.0.0
provider: ^6.0.5
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,20 @@ class HMSTrackSettingsExtension {
hmsAudioTrackSettings.enableNoiseCancellation(true)
}
}

val enableAutomaticGainControl = audioHashMap["enable_automatic_gain_control"] as? Boolean
enableAutomaticGainControl?.let {
if(it){
hmsAudioTrackSettings.enableAutomaticGainControl(true)
}
}

val enableNoiseSupression = audioHashMap["enable_noise_supression"] as? Boolean
enableNoiseSupression?.let {
if(it){
hmsAudioTrackSettings.enableNoiseSupression(true)
}
}
}

var hmsVideoTrackSettings = HMSVideoTrackSettings.Builder()
Expand Down
7 changes: 3 additions & 4 deletions packages/hmssdk_flutter/example/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,9 @@ packages:
hmssdk_flutter:
dependency: transitive
description:
name: hmssdk_flutter
sha256: "2da8500708d8a8ebfa3d3ffb2f1deafd0ff23828dfaff6fdd1b4367da6337cf0"
url: "https://pub.dev"
source: hosted
path: ".."
relative: true
source: path
version: "1.10.5"
http:
dependency: transitive
Expand Down
12 changes: 10 additions & 2 deletions packages/hmssdk_flutter/lib/src/model/hms_audio_track_setting.dart
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,20 @@ class HMSAudioTrackSetting {
///Refer: Read more about noise cancellation [here](///)
final bool enableNoiseCancellation;

final bool enableAutomaticGainControl;

final bool enableNoiseSupression;

HMSAudioTrackSetting(
{this.useHardwareAcousticEchoCanceler,
this.audioSource,
this.trackInitialState = HMSTrackInitState.UNMUTED,
this.audioMode,
this.phoneCallState =
HMSAndroidPhoneCallState.DISABLE_MUTE_ON_VOIP_PHONE_CALL_RING,
this.enableNoiseCancellation = false});
this.enableNoiseCancellation = false,
this.enableAutomaticGainControl = false,
this.enableNoiseSupression = false});

factory HMSAudioTrackSetting.fromMap(Map map) {
List<HMSAudioNode> nodeList = [];
Expand Down Expand Up @@ -109,7 +115,9 @@ class HMSAudioTrackSetting {
'phone_call_state':
HMSAndroidPhoneCallStateValue.getValuefromHMSPhoneCallState(
phoneCallState),
'enable_noise_cancellation': enableNoiseCancellation
'enable_noise_cancellation': enableNoiseCancellation,
'enable_automatic_gain_control': enableAutomaticGainControl,
'enable_noise_supression': enableNoiseSupression
};
}
}