Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Transform this repository into a ROS2 package - which allows it to be launched like via ros2 launch as any other node. #14

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

aentinger
Copy link
Member

No description provided.

@aentinger aentinger added type: enhancement PR to improve the project. topic: software Code that runs on a PC. labels May 17, 2023
@aentinger
Copy link
Member Author

Hi @wuehr1999 ☕ 👋

I've made some first steps towards transforming this repository towards a Python ROS2 package. Alas, its not really working. Can you please take a look at this and fix-up the missing parts of the node-setup and configuration?

I also imagine that somewhere the webgui directory path needs to be passed to the SimpleHTTPRequest handler. That could be done via ROS parameters and launch file (the same launch file that I imagine can be used to launch the rosbridge_webserver at the very same time) conveniently catching multiple flies with one singular strike 😁 .

@wuehr1999
Copy link
Member

Hi @aentinger,
in my opinion this package should not be delivered as a (Python) ROS2 package. Basically the frontend has nothing to do with Python or ROS on the system. It would be better to make it available as a debian package, that installs it as a service providing the static elements of the webpage.

@aentinger
Copy link
Member Author

Well, then we agree to disagree. This "software package" takes ROS topics and provides a GUI using a web-browser. Turning it into a ROS package will streamline installation of all L3XZ related software packages as they are all ROS packages. I'll proceed down this path 😝

@aentinger aentinger force-pushed the transitition-to-ros2node branch from 0116ea5 to 85c79ad Compare May 24, 2023 05:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: software Code that runs on a PC. type: enhancement PR to improve the project.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants