docs: Update dates.md with an actual inline fix for Liquid #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -120,7 +120,15 @@ display a date with a UTC time zone like: | |||
| Mon, 01 Jan 2018 00:00:00 GMT | |||
| ``` | |||
|
|
|||
| You could add your own `toUTCString` [filter in Liquid](/docs/filters/) to perform the same task. | |||
| On Liquid, you can't do this, though you can create your own `toUTCString` [filter in Liquid](/docs/filters/) to perform the same task, or pass a timezone parameter to your filter to point to the one you desire in your template. | |||
There was a problem hiding this comment.
Suggested change
| On Liquid, you can't do this, though you can create your own `toUTCString` [filter in Liquid](/docs/filters/) to perform the same task, or pass a timezone parameter to your filter to point to the one you desire in your template. | |
| On Liquid, you can't do this, though you can create your own `toUTCString` [filter in Liquid](/docs/languages/liquid/#filters) to perform the same task, or pass a timezone parameter to your filter to point to the one you desire in your template. |
I think this specific link is closer to the link text.
There was a problem hiding this comment.
Honestly, I just kept the original one from the team as I didn't touch that part specifically. Mostly edit it so it made sense to the follow up advice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks. While working with dates and dealing with UTC, I noticed that there was an easy inline fix in Liquid not mentioned in the documentation page. I think is quite simpler than having to build a whole filter pipeline.
This is extracted from LiquidJS official docs: https://liquidjs.com/filters/date.html
Let me know if you agree with me this is a valid extra bit of advice.