Switch back to hasOwnProperty

Attempt to fix issue #184
1904labs · Aug 26, 2024 · 77d9236 · 77d9236
1 parent 68e143a
commit 77d9236
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 24 deletions.
diff --git a/dist/dom-to-image-more.min.js b/dist/dom-to-image-more.min.js
diff --git a/dist/dom-to-image-more.min.js.map b/dist/dom-to-image-more.min.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,11 +1,11 @@
 {
     "name": "dom-to-image-more",
-    "version": "3.4.0",
+    "version": "3.4.1",
     "description": "Generates an image from a DOM node using HTML5 canvas and SVG",
     "main": "dist/dom-to-image-more.min.js",
     "devDependencies": {
         "chai": "^4.3.10",
-        "eslint": "^9.9.0",
+        "eslint": "^9.9.1",
         "grunt": "^1.6.1",
         "grunt-cli": "^1.5.0",
         "grunt-contrib-jshint": "^3.2.0",

diff --git a/src/dom-to-image-more.js b/src/dom-to-image-more.js
@@ -666,7 +666,7 @@
         function isInShadowRoot(value) {
             return (
                 value !== null &&
-                'getRootNode' in value &&
+                Object.prototype.hasOwnProperty.call(value, 'getRootNode') &&
                 isShadowRoot(value.getRootNode())
             );
         }
@@ -1124,7 +1124,12 @@
             function getCssRules(styleSheets) {
                 const cssRules = [];
                 styleSheets.forEach(function (sheet) {
-                    if ('cssRules' in Object.getPrototypeOf(sheet)) {
+                    if (
+                        Object.prototype.hasOwnProperty.call(
+                            Object.getPrototypeOf(sheet),
+                            'cssRules'
+                        )
+                    ) {
                         try {
                             util.asArray(sheet.cssRules || []).forEach(
                                 cssRules.push.bind(cssRules)