Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/utf8 support #169

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

cawmichael
Copy link
Contributor

No description provided.

@ottonomy
Copy link
Collaborator

Would love to see a test added to cover this task. I can do it if you don't have time.

You could use this test from test_graph.py as a base.

class HttpFetchingTests(unittest.TestCase):

    @responses.activate
    def test_basic_http_fetch_task(self):
        url = 'http://example.com/assertionmaybe'
        responses.add(
            responses.GET, url,
            body=test_components['2_0_basic_assertion'],
            status=200, content_type='application/ld+json'
        )
        task = add_task(FETCH_HTTP_NODE, url=url)

        success, message, actions = fetch_http_node({}, task)

        self.assertTrue(success)
        self.assertEqual(len(actions), 2)
        self.assertEqual(actions[0]['type'], STORE_ORIGINAL_RESOURCE)
        self.assertEqual(actions[1]['name'], INTAKE_JSON)

@ottonomy
Copy link
Collaborator

ottonomy commented Sep 27, 2017

@cawmichael @mgylling ugh, A bit stuck. Pushed what I had with a couple changes to the test to a local branch here in this repo: cawmichael-feature/utf8-support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants