use json() method of Response object #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on content-type encoding; prevents encoding errors / throws same error as json.loads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered a couple cases where the requests library didn't properly handle certain characters in JSON in UTF-8 when response.text was used, but we found that when a UTF-8 charset was forced on a response object, the resulting data was correctly represented in python unicode strings.
Turns out the responses library has a better handling of this with some better charset detection that is compatible with json built into its
Response.json()method. Thanks @jcreed-csky for the contribution.This PR updates the code to use json() method of Response object to resolve issues around content-type encoding: prevents encoding errors / throws same error as json.loads