Dispute actions info box: Consider cases where the round is appealed #84
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/1hive/celeste-dashboard/ALn3h5tVfMPfm9c4xRVW5XFXtNwK |
| if (hasVotedInConsensus) { | ||
| background = backgroundColor[appeal ? 'negative' : 'positive'] | ||
| icon = appeal ? IconVotingFailed : IconRewardsGreen | ||
| paragraph = appeal ? ( |
There was a problem hiding this comment.
maybe we can have this as an use memo or maybe get the data from a function instead of doing so many ? :
There was a problem hiding this comment.
Yeah i'll try to do an early return and see how it looks.
What do you mean getting the dats from a function? As you may notice i already separated this part in its own function, but there are so many different cases and conditions that i couldn't find a way to separate it and make it cleaner.
But we can try to do the early return. Also regarding the useMemo, note that the function is already inside an useMemo
There was a problem hiding this comment.
created an issue #90
Info box: Considers cases where round was appealed.
If a keeper voted in consensus with the plurality we would always show a positive message stating that they will receive rewards.
This is inaccurate as the round could have been appealed, making the final ruling different from the keeper's outcome during voting phase
For more context see #72