Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x11rb to v0.12 #101

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Mar 18, 2023

This updates x11rb to v0.11.

This increases the MSRV from v1.46 to v1.56. Which should be fine because the MSRV for image is also 1.56.

Waiting for a new release of wl-clipboard-rs with YaLTeR/wl-clipboard-rs@71b6df7.

Cargo.lock Outdated Show resolved Hide resolved
@daxpedda daxpedda changed the title Update x11rb to v0.11 Update x11rb to v0.12 May 27, 2023
@daxpedda
Copy link
Contributor Author

daxpedda commented Oct 5, 2023

@daxpedda daxpedda requested a review from complexspaces October 5, 2023 18:47
@daxpedda daxpedda mentioned this pull request Oct 5, 2023
@complexspaces
Copy link
Collaborator

Thanks for updating this PR again! Regarding the bitflags update, I don't see it as problematic for merging. Its the first semver incompatible change they've made in a long time and the rest of the crate ecosystem is working through it too.

I will spin up a Wayland VM by the end of the weekend to smoke check this, but otherwise I think this is good to merge once its been rebased for the CI fix you opened earlier.

@daxpedda
Copy link
Contributor Author

daxpedda commented Oct 6, 2023

[..], but otherwise I think this is good to merge once its been rebased for the CI fix you opened earlier.

Done.

Copy link
Collaborator

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this branch in both Wayland via KDE Plasma and then X11 and Wayland on Ubuntu and all tests passed, confirming the updates didn't have any noticeable behavior changes.

This is good to go now, thanks again!

@complexspaces complexspaces merged commit 48117d9 into 1Password:master Oct 8, 2023
7 checks passed
@complexspaces
Copy link
Collaborator

This is now released in v3.3.0. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants