Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.67.1 and fix CI didn't check MSRV #140

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Mar 4, 2024

Hi,

I investigated why #136 was not caught by CI. And I found that CI workflows for Rust 1.61 was actually using the latest stable toolchain.

This PR fixes the issue. I could confirm 1.61 was used properly on my fork.

info: syncing channel updates for '1.61-x86_64-unknown-linux-gnu'
info: latest update on 2022-05-19, rust version 1.61.0 (fe5b13d68 2022-05-18)

https://github.com/rhysd/arboard/actions/runs/8135373857/job/22229818914

Please note that CI will break after merging this PR. This is because wayland-backend crate requires Rust 1.65 or later.

error: package `wayland-backend v0.3.2` cannot be built because it requires rustc 1.65 or newer, while the currently active rustc version is 1.61.0

I didn't bump the MSRV of this crate in this PR because I'm not understanding the process. (If you prefer bumping MSRV in this PR, please let me know. I'll include the changes.)

@complexspaces
Copy link
Collaborator

Thanks for the PR @rhysd. I think we should go ahead and bump the MSRV in this PR.

because I'm not understanding the process.

All that needs done is:

1.65 is a reasonable target of "usefulness" because its when GATs became stable. Its also 1.5 years old so there has been ample time for adoption. If anyone comes by at a later point and says this has impacted their project somehow, I'm inclined to just remove wayland testing from our MSRV CI configuration and document the increased requirement. That's more effort then bumping it though so lets try the simpler option first.

@rhysd
Copy link
Contributor Author

rhysd commented Apr 10, 2024

Sure. Thank you for your response with the advices. I'll try to update this branch when I have time, hopefully within a few days.

@rhysd rhysd force-pushed the fix-ci-rust-version branch from e9e502e to 520b97d Compare April 11, 2024 11:28
@rhysd
Copy link
Contributor Author

rhysd commented Apr 11, 2024

After resolving the Rust 1.65 MSRV error, it turned out that more recent version was required by other crate. image crate requires 1.67.1 or newer.

To meet the requirement, I bumped this crate's MSRV to 1.67.1.

@rhysd rhysd changed the title Fix CI for Rust 1.61 doesn't use rustc 1.61 compiler Bump MSRV to 1.67.1 and fix CI didn't check MSRV Apr 11, 2024
@complexspaces complexspaces merged commit bb2e898 into 1Password:master Apr 12, 2024
11 checks passed
@complexspaces
Copy link
Collaborator

Thank you again for catching this and putting up a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants