Copy image as PNG file on Windows #141
Conversation
Klavionik
force-pushed
the
copy-image-as-png-file
branch
from
3a2b851 to
67e0b06
Compare
|
@complexspaces Just a kind reminder! I would be glad if you could find some time to review this. |
complexspaces
force-pushed
the
copy-image-as-png-file
branch
from
67e0b06 to
9f39de1
Compare
There was a problem hiding this comment.
Thank you for taking the time to make a PR! I took a bit too long to finish looking over this one, but I wanted to better understand how more of the Windows ecosystem handles transparent images. After looking through Firefox, Java, Chromium, etc I've convinced myself this is the right approach for better compatibility.
One thing I noticed is that other apps use DIBV5 plus BI_RGB as a secondary option to PNG encoding data. This is something arboard can look at later but isn't a blocker for this PR.
I took a look through your changes and only had a few minor codestyle comments. This needed rebased on main as well to pick up the recent image 0.25 update too. In order to save some time, since I already took a while to get around to reviewing this, I updated the branch myself with my suggestions.
complexspaces
force-pushed
the
copy-image-as-png-file
branch
from
9f39de1 to
3654907
Compare
|
Glad to hear it's merged! Thank you too, for taking care of the PR. |
|
This is now released in version 3.4.0 on crates.io. Please let us know if you run into any more issues. |
@complexspaces Hello! I decided to just go ahead and open a PR regarding the issue #135. Hope you don't mind.
I'm pretty new to Rust, so pardon me if I did something plain wrong here. :) Just wanted to help you understand the idea that I proposed in more detail.
Here's how it looks if you paste a transparent image into PowerPoint now:
And this is how it looked before: