Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image to 0.25 #142

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Update image to 0.25 #142

merged 1 commit into from
Apr 9, 2024

Conversation

torokati44
Copy link
Contributor

This should help with emilk/egui#4160.
(High five, @ArturKovacs! 😀 )

@torokati44 torokati44 mentioned this pull request Mar 24, 2024
Merged
2 tasks
@torokati44 torokati44 mentioned this pull request Apr 1, 2024
Closed
@torokati44
Copy link
Contributor Author

It's been a while, so ... bump? 😳

complexspaces
complexspaces requested changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay getting to this one. Thank you for the update here.

The current set of changes looks good, but it seems like some API changes are required? I'm happy to approve and merge this once those fixes are made.

@torokati44
Copy link
Contributor Author

Ah, yes, now that CI was finally allowed to run, I can see that... 😅
Sure, could also have checked locally... 😶🙄
I'll get on fixing it in an hour or two!

@complexspaces
Copy link
Collaborator

Sorry about that bad feedback cycle with CI 😓. Please don't feel any need to rush fixing this.

@torokati44
Copy link
Contributor Author

torokati44 commented Apr 9, 2024 •
edited
Loading

No worries, it's fine! ^^

Though, the fact that apparently every single CI run needs to be approved manually, and it's in fail-fast mode, might drag this out a little bit more, as I can only test on one platform myself. I'm in no rush though!

@complexspaces complexspaces merged commit f6fc4ea into 1Password:master Apr 9, 2024
11 checks passed
@torokati44
Copy link
Contributor Author

Thank you for the merge! 🥳
Now we only have to wait for a new release... 👀 🙏

@torokati44
Copy link
Contributor Author

Pinging in hopes for a new release soon? 🥺
(Merging without releasing is called being in the PRgatory.)

@complexspaces
Copy link
Collaborator

I have not forgotten about this one 😓. I am hoping to make some other tweaks this weekend before making a new minor release.

@torokati44
Copy link
Contributor Author

Ooh, amazing! 😊 That's fairly soon! Thank you!

@complexspaces
Copy link
Collaborator

This is now released in version 3.4.0 on crates.io. Thanks for your patience.

@torokati44
Copy link
Contributor Author

Yay, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@complexspaces complexspaces complexspaces approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torokati44 @complexspaces