Merge pull request #90 from 1inch/audits/SC-1218-Apply-audit-suggestions

Apply Consensys audit suggestions
1inch · Jul 31, 2024 · ef47c45 · ef47c45
2 parents 4374c1f + 1e24f9a
commit ef47c45
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/test/integration/MerkleStorageInvalidator.t.sol b/test/integration/MerkleStorageInvalidator.t.sol
@@ -24,6 +24,7 @@ contract MerkleStorageInvalidatorIntTest is BaseSetup {
         BaseSetup.setUp();
 
         for (uint256 i = 0; i < SECRETS_AMOUNT; i++) {
+            // Note: This is not production-ready code. Use cryptographically secure random to generate secrets.
             hashedSecrets[i] = keccak256(abi.encodePacked(i));
             hashedPairs[i] = keccak256(abi.encodePacked(i, hashedSecrets[i]));
         }

diff --git a/test/unit/EscrowFactory.t.sol b/test/unit/EscrowFactory.t.sol
@@ -25,6 +25,7 @@ contract EscrowFactoryTest is BaseSetup {
     function setUp() public virtual override {
         BaseSetup.setUp();
 
+        // Note: This is not production-ready code. Use cryptographically secure random to generate secrets.
         for (uint256 i = 0; i < SECRETS_AMOUNT; i++) {
             hashedSecrets[i] = keccak256(abi.encodePacked(i));
             hashedPairs[i] = keccak256(abi.encodePacked(i, hashedSecrets[i]));

diff --git a/test/unit/MerkleStorageInvalidator.t.sol b/test/unit/MerkleStorageInvalidator.t.sol
@@ -27,6 +27,7 @@ contract MerkleStorageInvalidatorTest is BaseSetup {
         bytes32[] memory hashedSecrets = new bytes32[](secretsAmount);
         bytes32[] memory hashedPairs = new bytes32[](secretsAmount);
 
+        // Note: This is not production-ready code. Use cryptographically secure random to generate secrets.
         for (uint256 i = 0; i < secretsAmount; i++) {
             hashedSecrets[i] = keccak256(abi.encodePacked(i));
             hashedPairs[i] = keccak256(abi.encodePacked(i, hashedSecrets[i]));
@@ -62,6 +63,7 @@ contract MerkleStorageInvalidatorTest is BaseSetup {
         bytes32[] memory hashedSecrets = new bytes32[](secretsAmount);
         bytes32[] memory hashedPairs = new bytes32[](secretsAmount);
 
+        // Note: This is not production-ready code. Use cryptographically secure random to generate secrets.
         for (uint256 i = 0; i < secretsAmount; i++) {
             hashedSecrets[i] = keccak256(abi.encodePacked(i));
             hashedPairs[i] = keccak256(abi.encodePacked(i, hashedSecrets[i]));